Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow persistence of firewall rules for Suse #1061

Merged
merged 2 commits into from
Aug 11, 2022
Merged

allow persistence of firewall rules for Suse #1061

merged 2 commits into from
Aug 11, 2022

Conversation

corporate-gadfly
Copy link
Contributor

allow persistence of firewall rules for Suse by using iptables-save.

@corporate-gadfly corporate-gadfly requested a review from a team as a code owner July 26, 2022 17:29
@CLAassistant
Copy link

CLAassistant commented Jul 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@corporate-gadfly
Copy link
Contributor Author

@david22swan : If you want to give it another whirl, I pushed another commit to possibly fix the Ruby syntax error.

david22swan
david22swan approved these changes Aug 11, 2022
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Not a complex change and the logic of it looks good so am happy to merge.

@david22swan david22swan merged commit 38295bd into puppetlabs:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@corporate-gadfly @CLAassistant @david22swan @ia-content @LukasAud