Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support --nflog-size as replacement for --nflog-range #1096

Merged
merged 1 commit into from
Dec 6, 2022
Merged

support --nflog-size as replacement for --nflog-range #1096

merged 1 commit into from
Dec 6, 2022

Conversation

kjetilho
Copy link
Contributor

@kjetilho kjetilho commented Dec 5, 2022

@kjetilho kjetilho requested a review from a team as a code owner December 5, 2022 11:29
@kjetilho kjetilho mentioned this pull request Dec 5, 2022
Merged
@jordanbreen28
Copy link
Contributor

jordanbreen28 commented Dec 5, 2022 •
edited
Loading

@kjetilho This is great!
There is some syntax errors present that seem to be causing the test failures, could you look to resolve these? (Whenever you have the time!)

@kjetilho kjetilho force-pushed the fix/nflog_size branch 2 times, most recently from 3388932 to f987d46 Compare December 5, 2022 14:12
@jordanbreen28
Copy link
Contributor

@kjetilho we have successful tests, outstanding work!
Thank you for your continued hard work on this one today!
Happy to go ahead and merge this change in if you are.

@kjetilho
Copy link
Contributor Author

kjetilho commented Dec 5, 2022

thanks! squashed and updated documentation - ready for merge if it still passes, I think :)

@jordanbreen28 jordanbreen28 merged commit e536564 into puppetlabs:main Dec 6, 2022
@kjetilho kjetilho deleted the fix/nflog_size branch February 14, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordanbreen28 jordanbreen28 jordanbreen28 approved these changes

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjetilho @jordanbreen28 @ia-content