(GH-1164) Only common jump values should be enforced as upcase #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Common jump values, depending on the OS, can be returned either as upcase or downcase values causing idempotentcy issues. This had previously been dealt with by simply enforcing upcase on all passed values. However this caused issues when passing chain's as the jump target and so the code has been update to explicitly upcase the common values only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common jump values, depending on the OS, can be returned either as upcase or downcase values causing idempotentcy issues. This had previously been dealt with by simply enforcing upcase on all passed values. However this caused issues when passing chain's as the jump target and so the code has been update to explicitly upcase the common values only.
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)