(#20912) Split argments while maintaining quoted strings #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github Bug: 182 Signed-off-by: Joe Julian <me@joejulian.name> (signed CLA)
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
ok to test |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-firewall-system/205/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-firewall-system/205/) |
|
So this patch here: kbarber@f921bdc replicates the issue. Can you cherry pick this into your branch? |
Signed-off-by: Ken Barber <ken@bob.sh>
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-firewall-system/213/) |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-firewall-system/213/) |
kbarber
added a commit
that referenced
this pull request
May 28, 2013
…hile_maintaining_quoted_strings (#20912) Split argments while maintaining quoted strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In delete_args, the parsing routine would split the line, but combine everything between the first and the last quote on the line. If there were multiple quoted strings this would combine arguments that should have been separate.
This combines all that into a single regex split that will keep quoted strings together.
Github Bug: 182
Signed-off-by: Joe Julian me@joejulian.name (signed CLA)