Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipv6 frag matchers2 and generify known_boolean handling. #207

Merged
merged 1 commit into from
Sep 13, 2013

Conversation

georgkoester
Copy link
Contributor

Adds tests for ipv6, too.

ip6tables handles fragmentation differently. There's a special
module and a couple 'frag' of matchers which are all needed to
implement a stateless firewall correctly.

known_boolean handling has been generified.
Before the known_boolean functionality was partly tailored
to the :socket feature.

(before #165).

@kbarber-jenkins-bot
Copy link

Can one of the admins verify this patch?

@georgkoester
Copy link
Contributor Author

Looks like the new nokogiri version wants a newer ruby release on Travis. Make nokogiri version sticky for the older ruby versions?

@kbarber
Copy link
Contributor

kbarber commented Jun 10, 2013

@georgkoester this test is failing due to a known issue with rspec-system 1.x and older rubies (nokogiri 1.6 suddenly dropped ruby 1.8.x support). The simplest solution is to rebase it and push again, it should fix it. You might also want to squash your patches up while you are at it.

@kbarber-jenkins-bot
Copy link

Can one of the admins verify this patch?

@apenney
Copy link
Contributor

apenney commented Jul 5, 2013

Hi,

I was wondering if this was still something you wanted to get merged in? I see Ken updated about a month ago to see if you could rebase it. No pressure from our side, just running through the PR list and thought I'd check in.

@georgkoester
Copy link
Contributor Author

I think I rebased in c122f4d (above your comment). I will do it again.

@georgkoester
Copy link
Contributor Author

Fails on Travis only. Failing code wasn't touched lately:

  1. iptables chain provider detection should default to iptables provider if /sbin/(eb|ip|ip6)tables[-save] exists
    Failure/Error: exists.any_instance.stubs(:which).with("ebtables").
    NoMethodError:
    undefined method `any_instance_recorder_for' for nil:NilClass

    ./spec/unit/puppet/provider/iptables_chain_spec.rb:18

exists.any_instance.stubs(:which).with("iptables").
returns "/sbin/iptables"

  1. iptables provider detection should default to iptables provider if /sbin/iptables[-save] exists
    Failure/Error: exists.any_instance.stubs(:which).with("iptables").
    NoMethodError:
    undefined method `any_instance_recorder_for' for nil:NilClass

    ./spec/unit/puppet/provider/iptables_spec.rb:18

exists.any_instance.stubs(:which).with("ebtables").
returns "/sbin/ebtables"

Adds tests for ipv6, too.

ip6tables handles fragmentation differently. There's a special
module and a couple of matchers which are all needed to
implement a stateless firewall correctly.

known_boolean handling with etc has been generified.
The known_boolean functionality was partly tailored
to the :socket feature.
@georgkoester
Copy link
Contributor Author

Travis is happy!

@hunner
Copy link
Contributor

hunner commented Jul 10, 2013

This looks cool and useful. rspec-system tests would be cool, but not required as there is not much coverage in the first place.

@kbarber thoughts?

@apenney apenney merged commit ce61a24 into puppetlabs:master Sep 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants