-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ipv6 frag matchers2 and generify known_boolean handling. #207
Add ipv6 frag matchers2 and generify known_boolean handling. #207
Conversation
|
Can one of the admins verify this patch? |
|
Looks like the new nokogiri version wants a newer ruby release on Travis. Make nokogiri version sticky for the older ruby versions? |
|
@georgkoester this test is failing due to a known issue with rspec-system 1.x and older rubies (nokogiri 1.6 suddenly dropped ruby 1.8.x support). The simplest solution is to rebase it and push again, it should fix it. You might also want to squash your patches up while you are at it. |
|
Can one of the admins verify this patch? |
|
Hi, I was wondering if this was still something you wanted to get merged in? I see Ken updated about a month ago to see if you could rebase it. No pressure from our side, just running through the PR list and thought I'd check in. |
|
I think I rebased in c122f4d (above your comment). I will do it again. |
|
Fails on Travis only. Failing code wasn't touched lately:
exists.any_instance.stubs(:which).with("iptables").
exists.any_instance.stubs(:which).with("ebtables"). |
Adds tests for ipv6, too. ip6tables handles fragmentation differently. There's a special module and a couple of matchers which are all needed to implement a stateless firewall correctly. known_boolean handling with etc has been generified. The known_boolean functionality was partly tailored to the :socket feature.
|
Travis is happy! |
|
This looks cool and useful. rspec-system tests would be cool, but not required as there is not much coverage in the first place. @kbarber thoughts? |
Adds tests for ipv6, too.
ip6tables handles fragmentation differently. There's a special
module and a couple 'frag' of matchers which are all needed to
implement a stateless firewall correctly.
known_boolean handling has been generified.
Before the known_boolean functionality was partly tailored
to the :socket feature.
(before #165).