Update providers to use expect syntax #217
Conversation
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-firewall/315/) |
The expect syntax is much better than the should syntax and ships with RSpec 2.14. It caused a few conflicts with the mocha stubbing, so I updated the docs to use rspec test doubles instead.
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build finished. (Status: FAILURE, Details: http://box.bob.sh:8080/job/puppetlabs-firewall/315/) |
|
LGTM, particularly because it fixes the builds errors since rspec 2.14 was released. Do you know why puppetlabs_spec_helper favours mocha? Will this follow through as a recommendation to that and other puppetlabs modules that use it? |
|
retest this please |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-firewall/320/) |
Update providers to use expect syntax
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-firewall/320/) |
The expect syntax is much better than the should syntax and ships with RSpec 2.14. It caused a few conflicts with the mocha stubbing, so I updated the docs to use rspec test doubles instead.