-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/master/add support for iprange #219
Feature/master/add support for iprange #219
Conversation
Add support for filtering by source and destination IP range, equivalent to '-m iprange --src-range|--dst-range', which is only allowing a specified IP range. Excluding an IP range, '! --src-range or ! --dst-range', is not supported. Add ':src_range' and ':dst_range' to firewall.rb
Add support for filtering by source and destination IP range, equivalent to '-m iprange --src-range|--dst-range', which is only allowing a specified IP range. Excluding an IP range, '! --src-range or ! --dst-range', is not supported. Add ':src_range' and ':dst_range' to iptables.rb
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-firewall/318/) |
|
Merged build finished. (Status: FAILURE, Details: http://box.bob.sh:8080/job/puppetlabs-firewall/318/) |
|
@hurulu Looks like this isn't passing on centos 5.9 http://box.bob.sh:8080/job/puppetlabs-firewall/318/RSPEC_SET=centos-59-x64/consoleFull |
|
Hi hunner, Thank you for your feedback. I've had a quick look at this. It seems like iptables 1.3.5 doesn't support this format: If this is the case, any advice? |
|
@hunner , Hi, I've just gone through iptables 1.3.4 - 1.4.0. It turns out that >=1.3.6 will work well. Unfortunately, version 1.3.5, which is the default on CentOS5.9, does not support multiple '-m iprange' format. And all the versions<1.3.5 will fail to pass the test. |
|
Merged build triggered. (Status: PENDING, Details: null) |
|
Merged build started. (Status: PENDING, Details: http://box.bob.sh:8080/job/puppetlabs-firewall/322/) |
|
I played around in centos 5.9 and patching the parser to know to only include |
|
Merged build finished. (Status: SUCCESS, Details: http://box.bob.sh:8080/job/puppetlabs-firewall/322/) |
…range Feature/master/add support for iprange
|
Thank you, hunner |
…ort-for-iprange Feature/master/add support for iprange
Closes #215
Closes #216