Add SL and SLC cases for operatingsystem

[traylenator]

No description provided.

[kbarber-jenkins-bot]

Can one of the admins verify this patch?

[traylenator]

I've seen this message a few times now.. Who are the 'admins'

[apenney]

For something like this it's "anyone at puppetlabs that would have cause to merge things in modules". Specifically these days that's me, @hunner, @kbarber. We're in the process of reworking how we handle modules and PRs and who is responsible and all those good things right nwo to make sure these things happen a little more timely and responsibilities are clear (in the past the person who made the module tended to retain responsibility for it, no matter what else they were doing at puppetlabs).

In the case of this specific PR there are two test failures which can be seen at https://travis-ci.org/puppetlabs/puppetlabs-firewall/builds/8887457 that hold us up from merging this. I can take a look as well if you're unable to figure out why these might be failing (I've only loosely touched this module before so it's going to take me some time to figure it out also).

[dcarley]

The spec failure isn't related to the change. It looks like a newer version of rspec-mocks has appeared and broken the stubs for provider detection.

• Before: https://travis-ci.org/puppetlabs/puppetlabs-firewall/jobs/8141013#L45
• After: https://travis-ci.org/puppetlabs/puppetlabs-firewall/jobs/8868746#L46

[dcarley]

In fact, looks like that will be fixed by #217

[apenney]

You know, I -just- talked to hunner about this yesterday and managed to forget it by this morning. I've merged in #217 and now I'm going to merge this too.