Generate parser list #248
Merged
Generate parser list #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Thanks for this! Sorry it's taken so long to get to, this module has been neglected for a while now. I'll try to do better about keeping on top of things. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-firewall
that referenced
this pull request
Oct 23, 2017
Generate parser list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated pull-request, now with spec test.
This patch should fix parsing iptables-save output from iptables lines as generated by system-config-firewall-tui.
Example line: -A INPUT -m state --state RELATED,ESTABLISHED -j ACCEPT
Before patch: firewall { '9004 dc0f1adfee77aa04ef7fdf348860a701':
ensure => 'present',
action => 'accept',
chain => 'INPUT',
dport => ['NEW'],
proto => 'tcp',
state => ['22'],
table => 'filter',
}
After patch: firewall { '9004 dc0f1adfee77aa04ef7fdf348860a701':
ensure => 'present',
action => 'accept',
chain => 'INPUT',
dport => ['22'],
proto => 'tcp',
state => ['NEW'],
table => 'filter',
}