(MODULES-439) Work around existing rules #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The firewall resource is not intended to be used with rules that are not also managed by puppet; the behavior when doing so was undefined. This is an attempt to make it more defined. The behavior is that any rule added by puppet will be inserted in its given order in relation to the other rules managed by puppet, but ahead of any rules not managed by puppet.
| @@ -408,8 +408,39 @@ def insert_order | |||
| # No rules at all? Just bail now. | |||
| return 1 if rules.empty? | |||
There was a problem hiding this comment.
What if the rule to edit is on a different chain?
There was a problem hiding this comment.
Resolved. Firewall doesn't support moving rules between chains.
There was a problem hiding this comment.
Hahaha, I love this "Resolved: WONTFIX." :D
ghost
assigned
apenney
pushed a commit
that referenced
this pull request
Jan 29, 2014
(MODULES-439) Work around existing rules
hunner
added a commit
to hunner/puppetlabs-firewall
that referenced
this pull request
Feb 6, 2014
In puppetlabs#286 we fixed rule offset detection for existing managed and unmanaged rules, but in the case where the first rule in a chain was unmanaged, managed rules were still being inserted under it. This patch changes it so that if the first rule detected for offset is unmanaged, then we should insert before that for more consistent behavior.
apenney
pushed a commit
that referenced
this pull request
Feb 8, 2014
Fix for #286 for pre-existing rules at the start of a chain
|
I don't understand how this change is supposed to benefit me. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-firewall
that referenced
this pull request
Oct 23, 2017
In puppetlabs#286 we fixed rule offset detection for existing managed and unmanaged rules, but in the case where the first rule in a chain was unmanaged, managed rules were still being inserted under it. This patch changes it so that if the first rule detected for offset is unmanaged, then we should insert before that for more consistent behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firewall resource is not intended to be used with rules that are not
also managed by puppet; the behavior when doing so was undefined. This
is an attempt to make it more defined.
The behavior is that any rule added by puppet will be inserted in its
given order in relation to the other rules managed by puppet, but ahead
of any rules not managed by puppet.