Fix for #286 for pre-existing rules at the start of a chain #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In puppetlabs#286 we fixed rule offset detection for existing managed and unmanaged rules, but in the case where the first rule in a chain was unmanaged, managed rules were still being inserted under it. This patch changes it so that if the first rule detected for offset is unmanaged, then we should insert before that for more consistent behavior.
| apply_manifest(pp, :catch_failures => true) | ||
|
|
||
| expect(shell('/sbin/iptables-save').stdout).to match(/-A INPUT -s 1\.2\.1\.1\/32 -p tcp \n-A INPUT -s 1\.2\.1\.1\/32 -p udp/) | ||
| end |
There was a problem hiding this comment.
This is a testing attempt for #301 and is how I found the issue fixed in this PR.
apenney
pushed a commit
that referenced
this pull request
Feb 8, 2014
Fix for #286 for pre-existing rules at the start of a chain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #286 we fixed rule offset detection for existing managed and
unmanaged rules, but in the case where the first rule in a chain was
unmanaged, managed rules were still being inserted under it.
This patch changes it so that if the first rule detected for offset is
unmanaged, then we should insert before that for more consistent
behavior.