Bugfix: Account for rules sorted after unmanaged rules #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The offset calculation assumed unmanaged rules are numbered 9000+ and would be sorted to the end and didn't need to be accounted for. This caused failures when people used9-numbered rules. This should fix that. Additionally, for rules that are 9-numbered, they should be ordered *after* unmanaged rules, so this fixes that too. So when encountering unmanaged rules, the order will be something like this: - Managed rules that begin with 0 through 8 - Unmanaged rules (which are assigned 9-numbers) - Managed rules that begin with 9 (but not numbered lower than the unmanaged rules) Mixing unmanaged rules with managed rules is still not officially supported, but at least we can try and behave with them.
apenney
pushed a commit
that referenced
this pull request
Feb 20, 2014
Bugfix: Account for rules sorted after unmanaged rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The offset calculation assumed unmanaged rules are numbered 9000+ and would be sorted to the end and didn't need to be accounted for. This caused failures when people used9-numbered rules. This should fix that.
Additionally, for rules that are 9-numbered, they should be ordered after unmanaged rules, so this fixes that too.
So when encountering unmanaged rules, the order will be something like this:
Mixing unmanaged rules with managed rules is still not officially supported, but at least we can try and behave with them.