Add support for mac address source rules pt2 #337
Conversation
|
Would it be possible to add some acceptance tests for this? You can look in spec/acceptance for examples of how to test parameters. |
|
I'm hitting this bug and made the same fix myself. Fortunately I checked open pull requests before submitting my own. Let me know if I can help out with this one. |
|
+1 |
|
Any news on being able to add acceptance tests? you can crib existing examples out of spec/acceptance to make it easy. You can run them with rspec spec/acceptance if you have vagrant/virtualbox installed to test them. |
|
I somehow missed your previous comment. |
|
This patch fixed MAC address issue for me. |
|
+1 |
|
+1 |
|
I like this (and the acceptance test is fine) but I find it confusing that it's called mac_addr and not mac_source after the actual argument we're passing to iptables. How do you feel about renaming it to mac_source? I'd happily merge it. |
|
Done. |
|
Can you rebase this? I wanted to merge but I can't. :( |
|
Done. |
|
Any plans regarding merging this PR? |
|
+1, let's merge it. We are already using it. |
|
worked for me. |
|
@apenney Do you plan to merge this? |
|
Please merge this, I will give you one non-refundable virtual 🍪 |
|
Or we can start doing some voodoo ritual which will make some powerful spirit merge this PR instead of @apenney :) |
This is necessary to parse rules generated on OpenStack Havana + Neutron + OpenVSwitch
* Missing type definition * Fix failing test * Acceptance testing + fix parameter match * Renamed mac_addr to mac_source
|
I would love to see this merged also :). |
Add support for mac address source rules pt2
|
As promised, a 🍪 for @hunner. Thanks! |
PR #334 was not complete. I've added type definition.