Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-689) Add support for connlimit and connmark #344

Merged
merged 2 commits into from
Apr 22, 2014
Merged

(MODULES-689) Add support for connlimit and connmark #344

merged 2 commits into from
Apr 22, 2014

Conversation

csschwe
Copy link
Contributor

@csschwe csschwe commented Apr 17, 2014

This adds support for the use of connlimit and connmark
eg.

  firewall { '400 connlimit exceeded LOG':
    chain           => 'INPUT',
    proto           => 'tcp',
    dport           => '22',
    connlimit_above => '10',
    connlimit_mask  => '32',
    connmark        => '0x1',
    log_prefix      => '* connlimit exceeded *',
    jump            => 'LOG',
  }

@csschwe csschwe changed the title Add support for connlimit and connmark [MODULES-689] Add support for connlimit and connmark Apr 17, 2014
@csschwe csschwe changed the title [MODULES-689] Add support for connlimit and connmark (MODULES-689) Add support for connlimit and connmark Apr 17, 2014
apenney
apenney reviewed Apr 17, 2014
View reviewed changes
spec/acceptance/connlimit_spec.rb
describe 'firewall type' do

describe 'connlimit_above' do
context '50' do
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand where the 50 comes from, probably needs a friendlier name here :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to call it 10 to go along with the parameter, fixed. Thanks

apenney pushed a commit that referenced this pull request Apr 22, 2014
Merge pull request #344 from csschwe/add_connection_limit
85b32f0 
(MODULES-689) Add support for connlimit and connmark
@apenney apenney merged commit 85b32f0 into puppetlabs:master Apr 22, 2014
@csschwe csschwe deleted the add_connection_limit branch March 7, 2015 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csschwe @apenney @david22swan