(MODULES-464) Add netmap feature #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrobinson
changed the title
|
Hi @Nemski, in general this looks good, but could you update acceptance tests? Also, this is going to need a rebase. Thanks! |
|
@mhaskel Added tests and rebased |
|
@Nemski Can you squash this down to a single commit? But otherwise, looking good! |
patrobinson
force-pushed
the
bug/master/add_netmap
branch
from
432ec03
to
f45fa3b
Compare
|
@mhaskel Ok squashed now (i'm learning a lot about Git now) |
underscorgan
pushed a commit
that referenced
this pull request
Dec 19, 2014
(MODULES-464) Add netmap feature
|
Thanks @Nemski! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-firewall
that referenced
this pull request
Oct 23, 2017
(MODULES-464) Add netmap feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#464) Add the ability to manage netmap rules.
Change resource_map in iptables provider to map "--to" parameter, which allows for parsing of existing netmap rules in rules_to_hash method.
Change resource_list in iptables provider to map append "--to" parameter when inserting netmap rules.
Add firewall type property "to".
Add feature netmap.
Example:
firewall { "151 NAT rules":
ensure => "present",
chain => "PREROUTING",
jump => "NETMAP",
destination => "10.168.34.0/24",
to => "192.168.34.0/24",
table => "nat",
source => "192.168.1.0/24",
proto => "all",
}