Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-1976) Revise rule name validation for ruby 1.9 #517

Conversation

karmix
Copy link
Contributor

@karmix karmix commented Apr 24, 2015

Note: This test will only fail for ruby 1.9 and above. I was unable to find a way to reproduce the character encoding functionality introduced in 1.9 on previous versions of ruby in order to construct a test that is useful in those environments.

@bmjen
Copy link
Contributor

bmjen commented Apr 28, 2015

Thanks for the contribution @karmix! The parser in this module isn't something we like to modify too frequently. Do you have a specific reason for wanting special characters in the rule name?

@jonnytdevops
Copy link
Contributor

Hi There

Is this related to #513 at all?

Thanks

@karmix
Copy link
Contributor Author

karmix commented May 6, 2015

No. These are different issues. I encountered them separately.

Thanks

@jonnytdevops
Copy link
Contributor

Hi Karmix

I'm a bit confused about your statement "This test will only fail for ruby 1.9 and above". Are you saying that your changes wont work on Ruby >=1.9, or that your changes have fixed an issue that would have occured on Ruby >=1.9 otherwise?

Thanks

@karmix
Copy link
Contributor Author

karmix commented Jun 18, 2015

This patch addresses a difference in the way unicode and non-unicode strings match regular expressions in Ruby >= 1.9. What I was trying to say was that the test I added to spec/fixtures/iptables/conversion_hash.rb will never fail on Ruby < 1.9, where unicode support is not present.

jonnytdevops added a commit that referenced this pull request Jun 19, 2015
…de-rule-name-validation

(MODULES-1976) Revise rule name validation for ruby 1.9
@jonnytdevops jonnytdevops merged commit 8ada3c4 into puppetlabs:master Jun 19, 2015
cegeka-jenkins pushed a commit to cegeka/puppet-firewall that referenced this pull request Oct 23, 2017
…1976_unicode-rule-name-validation

(MODULES-1976) Revise rule name validation for ruby 1.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants