Add --wait to iptables commands #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwhahaha
force-pushed
the
iptables-wait
branch
6 times, most recently
from
b6cc92c
to
dfc7d72
Compare
This change adds the --wait flag to the insert/update/delete iptables actions to prevent failures from occuring when iptables is running outside of puppet. Previously if a script or a user is running iptables commands while puppet is running, there may be failures in the firewall provider if iptables cannot get a lock. By default, iptables will just fail with an error so using --wait will make it wait until a lock can be established. The --wait is only added for iptables >= 1.4.20.
mwhahaha
force-pushed
the
iptables-wait
branch
from
dfc7d72
to
a407bcd
Compare
|
+1 |
1 similar comment
|
+1 |
|
Thanks for the great PR ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the --wait flag to the insert/update/delete iptables
actions to prevent failures from occuring when iptables is running
outside of puppet. Previously if a script or a user is running iptables
commands while puppet is running, there may be failures in the firewall
provider if iptables cannot get a lock. By default, iptables will just
fail with an error so using --wait will make it wait until a lock can be
established.