Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gid lookup #682

Merged
merged 2 commits into from
Nov 2, 2017
Merged

Add gid lookup #682

merged 2 commits into from
Nov 2, 2017

Conversation

crispygoth
Copy link
Contributor

The "uid" parameter for the firewall type correctly deals with mapping between usernames and UIDs as required, however the same isn't true for GIDs, which leads to spurious changes on every puppet run. This PR adds a similar mapping to GIDs.

@david22swan
Copy link
Member

@crispygoth Could you please add your changes to the docs

@crispygoth
Copy link
Contributor Author

Not sure what docs need updating here, could you point me in the right direction?

As far as I can see the gid option is both described in the README.markdown already as accepting a "GID or Group owner", mirroring the uid option which accepts a "UID or user name". The "forward" mapping of the group name to GID already worked fine. The only thing I've changed with this PR is fixing the "reverse" mapping so that if a group name is specified then it correctly maps the group name in the config to the GID it gets back from the iptables command, which stops it from considering the rule out of sync and trying to "update" the rule every time the agent runs.

@david22swan
Copy link
Member

Misread the commit, my apologies. Will give the commit a once over the first chance I get.

@david22swan david22swan merged commit db8ae47 into puppetlabs:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants