(MODULES-5645) Choose correct IP version for hostname resolution #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently hostnames specified in a `source` or `destination` field in a firewall rule are always resolved as IPv4, even when the provider is `ip6tables`. Instead, intelligently determine whether the hostname should be resolved as an IPv4 address or IPv6 address based on the provider.
|
Thanks @kpengboy ! |
|
This code actually breaks our Rspec tests - they fail to find the provider. With this in place, is there something I need to do to our spec tests to mock out the provider detection? |
|
@diranged would you mind submitting a ticket for this in JIRA? https://tickets.puppet.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently hostnames specified in a
sourceordestinationfieldin a firewall rule are always resolved as IPv4, even when the
provider is
ip6tables. Instead, intelligently determine whetherthe hostname should be resolved as an IPv4 address or IPv6 address
based on the provider.