Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-6029) Skip unparsable rules with warning #738

Merged
merged 1 commit into from
Nov 23, 2017

Conversation

jistr
Copy link
Contributor

@jistr jistr commented Nov 23, 2017

The iptables rules parser has very strict/simplistic expectations
about how iptables rules should look like, and can easily fail to
parse rules that weren't produced by the module itself.

We should ignore the unfitting rules when parsing and produce a
warning rather than causing a fatal error and stopping the Puppet run.

The iptables rules parser has very strict/simplistic expectations
about how iptables rules should look like, and can easily fail to
parse rules that weren't produced by the module itself.

We should ignore the unfitting rules when parsing and produce a
warning rather than causing a fatal error and stopping the Puppet run.
@pmcmaw pmcmaw merged commit 8d2cadb into puppetlabs:master Nov 23, 2017
@pmcmaw
Copy link
Contributor

pmcmaw commented Nov 23, 2017

@jistr thank you for your contribution.
It is much appreciated 👍

@jistr
Copy link
Contributor Author

jistr commented Nov 23, 2017

Thank you!

@pmcmaw
Copy link
Contributor

pmcmaw commented Nov 23, 2017

@jistr If you are waiting on a release of the module please let me know and I will get to work on it asap.

@jistr
Copy link
Contributor Author

jistr commented Nov 23, 2017

@pmcmaw We're trailing master in RDO project trunk repositories, we already have an RPM package generated from the merged commit, so there's no further hurry (we just need to promote trunk repos to stable repos now, which is on the RDO side anyway). Thanks for the quick responses and being helpful when addressing this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants