(MODULES-6340) - Address failure when name begins with 9XXX

[eimlav]

When a user specifies a firewall rule starting with a value between 9000-9999, the following error is thrown:

Error: Could not set 'present' on ensure: undefined method `+' for nil:NilClass at /root/manifest.pp:2

The following change addresses this by raising a more appropriate error and providing information in the README as to why this error occurs.

[jonnytdevops]

I'm not sure I would put this exception inside the provider. The code you've added is checking for nil, and while it is indeed nil for ranges 9000-9999, is may also be nil to as yet unidentified faults.

My recommendation is to:

• Change the wording to the exception inside the provider to be more generic (e.g. "sorted error detected" or something like that)
• Add an exception to the type to explicitly disallow a title starting with 9000-9999

Cheers

JT

[eimlav]

@jonnytdevops Initially I had put the exception in the type however the issue I encountered with this is that because the module assigns unmanaged rules a corresponding firewall type including a title with a value in the range 9000-9999 as intended, this will cause any call to retrieve a firewall resource to fail. This is because Puppet encounters these unmanaged resources and matches their title including the 9000-9999 range as being invalid. Perhaps there would need to be an additional property stating whether the resource refers to an unmanaged rule? What are you thoughts on this?

[jonnytdevops]

@eimlav Ah, yes, that is a good point. My suggestion at this point is to somehow tell inside the provider exception if the error is indeed due to a 9000-9999 issue and base the output text on that.

An easier thing you could do is to change the generic error message to provide a indicative advisory (e.g. "Rule sorting error. Make sure that the title of your rule does not start with 9000-9999, as this range is reserved) rather than stating the issue even though we're not sure. It's a "This could be the issue" vs "This is the issue" difference :)

Cheers

JT