(MODULES-8360) Fix IPv6 bug relating to Bugzilla 1015 #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fix for Bugzilla puppetlabs#1015 was added in 6807381. However, it appears that the bug description at https://bugzilla.netfilter.org/show_bug.cgi?id=1015 is not quite accurate, and the -p all hack is required sometimes, but not always. I don't know exactly when it is or isn't required. This patch changes the logic to try both.
alex-harvey-z3q
force-pushed
the
alexharvey/further_changes_for_MODULES-2119
branch
from
f0ab498
to
58d73c0
Compare
|
Rubocop got me. Have to figure out how to ignore the HandleExceptions check. |
alex-harvey-z3q
changed the title
alex-harvey-z3q
changed the title
|
See also #797 |
alex-harvey-z3q
force-pushed
the
alexharvey/further_changes_for_MODULES-2119
branch
from
58d73c0
to
4d76ea2
Compare
A fix for Bugzilla puppetlabs#1015 was added in 6807381. However, it appears that the bug description at https://bugzilla.netfilter.org/show_bug.cgi?id=1015 is not quite accurate, and the -p all hack is required sometimes, but not always. I don't know exactly when it is or isn't required. This patch changes the logic to try both.
alex-harvey-z3q
force-pushed
the
alexharvey/further_changes_for_MODULES-2119
branch
from
4d76ea2
to
161d900
Compare
|
@alexharv074 Thanks for the contribution! This looks good to me so I'm going to go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for Bugzilla #1015 was added in
6807381. However, it appears that the
bug description at https://bugzilla.netfilter.org/show_bug.cgi?id=1015
is not quite accurate, and the -p all hack is required sometimes, but
not always. I don't know exactly when it is or isn't required.
This patch changes the logic to try both.