Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FM-8400 - add debian10 support #862

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Conversation

lionce
Copy link
Contributor

@lionce lionce commented Oct 8, 2019

No description provided.

@lionce lionce requested a review from a team as a code owner October 8, 2019 11:47
@lionce lionce changed the base branch from FM-8356 to master October 8, 2019 11:50
@lionce
Copy link
Contributor Author

lionce commented Oct 8, 2019

Pipelines are green
successfully ran on debian10

@lionce lionce changed the title WIP - add debian10 support FM-8400 - add debian10 support Oct 8, 2019
@RandomNoun7 RandomNoun7 merged commit 3614e5d into puppetlabs:master Oct 8, 2019
@lionce lionce added the feature label Oct 8, 2019
@LiohMoeller
Copy link

Debian Buster uses nftables by default. In order to be able to use iptables '/usr/sbin/iptables-legacy-save' has to be used. The test pipeline does not reflect the actual production code and will always 'go green' like this.

One way to make it work could be:

when :Debian_manual
  case proto.to_sym
  when :IPv4
    if os_key == 'Debian' && Facter.value(:operatingsystem) == 'Debian' && Facter.value(:operatingsystemrelease).to_i >= 10
      ['/bin/sh', '-c', '/usr/sbin/iptables-legacy-save > /etc/iptables/rules']
    else
      ['/bin/sh', '-c', '/sbin/iptables-save > /etc/iptables/rules']
    end
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants