Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend LOG options #914

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Extend LOG options #914

merged 1 commit into from
Apr 30, 2020

Conversation

martialblog
Copy link
Contributor

@martialblog martialblog commented Apr 22, 2020

Hello,

I added booleans for the LOG options --log-tcp-sequence --log-tcp-options --log-ip-options

Let me know if you need any changes to the PR. Happy to help.

Cheers,
Markus

@martialblog martialblog requested a review from a team as a code owner April 22, 2020 07:53
@martialblog
Copy link
Contributor Author

PS: I coudn't get the acceptence tests to work as described in the CONTRIBUTING.md 🤔 Still trying to figure it out

 - Adds booleans for --log-tcp-sequence, --log-tcp-options, --log-ip-options
@daianamezdrea
Copy link
Contributor

Hi @martialblog, thank you for your contribution, let me know if you need some help!

@daianamezdrea daianamezdrea merged commit c05928b into puppetlabs:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants