Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IAC-899] - Add acceptance test for string_hex parameter #930

Merged
merged 3 commits into from
Jul 16, 2020
Merged

[IAC-899] - Add acceptance test for string_hex parameter #930

merged 3 commits into from
Jul 16, 2020

Conversation

adrianiurca
Copy link
Contributor

@adrianiurca adrianiurca commented Jul 16, 2020 •
edited
Loading

Closes: #923 and closes #924

@adrianiurca adrianiurca requested a review from a team as a code owner July 16, 2020 09:19
@puppet-community-rangefinder
Copy link

firewall is a type

Breaking changes to this file WILL impact these 124 modules (exact match):
Breaking changes to this file MAY impact these 144 modules (near match):

This module is declared in 110 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@mnejedlo-tds @adrianiurca
fix parsing of '! --hex-string' from iptables-save
69415a9 
iptables-save outputs the value of --hex-string inside quotes, which was
causing quotes inside quotes problems with the value.  This change adds
a special case parser for --hex-string to get the ! inside the quotes
and eliminate the doubled quotation marks
@adrianiurca adrianiurca changed the title Add acceptance test hex string [IAC-899] - Add acceptance test hex string Jul 16, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@602f744). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #930   +/-   ##
=========================================
  Coverage          ?   81.08%           
=========================================
  Files             ?       11           
  Lines             ?     1660           
  Branches          ?        0           
=========================================
  Hits              ?     1346           
  Misses            ?      314           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 602f744...69415a9. Read the comment docs.

This was referenced Jul 16, 2020
Closed
Closed
@sanfrancrisko sanfrancrisko changed the title [IAC-899] - Add acceptance test hex string [IAC-899] - Add acceptance test for string_hex parameter Jul 16, 2020
@sanfrancrisko sanfrancrisko merged commit 3e0437b into puppetlabs:master Jul 16, 2020
@mnejedlo-tds
Copy link
Contributor

mnejedlo-tds commented Jul 16, 2020 •
edited
Loading

For completeness sake, I should point out that the test included here doesn't test #924. The test for #924 needs to test the negation of --hex-string, e.g. "iptables ! --hex-string |fe ed fa ce|" <=> 'string-hex => "! |fe ed fa ce|"', while the test in this PR is for a non-negated --hex-string.

@adrianiurca
Copy link
Contributor Author

Hey @mnejedlo-tds, you're right. Thank you for your observation. I will submit a new PR which includes a new unit test and a new acceptance test(if required). And if something goes wrong we will raise a ticket for corrections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanfrancrisko sanfrancrisko sanfrancrisko approved these changes

Assignees
No one assigned
Labels
bugfix feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianiurca @codecov-commenter @mnejedlo-tds @sanfrancrisko