Add acceptance and unit test

[adrianiurca]

Closes: #908

[puppet-community-rangefinder]

firewall is a type

Breaking changes to this file WILL impact these 124 modules (exact match):

• echoes-echoes_firewall
• binarin-binarin
• gnubilafrance-nfs
• abiquo-abiquo
• sat6qe-katellovirt
• tomkrieger-security_baseline
• openstack-pacemaker
• karume-openstack
• narasimhasv-openstack
• andrewkroh-base_firewall
• aco-tomcat
• puppetfinland-packetfilter
• puppetlabs-openstack
• hesco-weave
• thias-rhel
• geoffwilliams-r_profile
• fervid-secure_linux_cis
• jmkeyes-gocd
• mvasilenko-gocd
• jgazeley-monyog
• compass-rserve
• dhollinger-devopsdays
• eelcomaljaars-friendica
• radez-pacemaker
• myoung34-mirthconnect
• jgazeley-speedtest
• gabe-pe_razor_complete
• compass-examdb
• inkling-postgresql
• thoherr-railsapp
• enterprisemodules-wls_profile
• jlambert121-puppet
• sjoeboo-puppet
• myoung34-marklogic
• 42ways-railsapp
• maxchk-varnish
• wdec-monit
• echoes-monit
• wdec-echoes_monit
• rendhalver-nrpe
• abstractit-nrpe
• tufin-secureapp
• evenup-riakdev
• soli-monit
• fraenki-galera
• godp1301-postgresql
• puppet-cassandra
• themeier-ssh
• enterprisemodules-ora_profile
• evenup-puppet
• pennycoders-marathon
• pennycoders-zookeeper
• alexharvey-firewall_multi
• olevole-ssh
• ghoneycutt-ssh
• locp-cassandra
• Nextdoor-strongswan
• glarizza-profiles
• pltraining-selfpaced
• mdelaney-icecc
• myoung34-hbase
• danfoster-networker
• jgazeley-networker
• puppetlabs-awsdemo_profiles
• jgazeley-ekahau_throughput_server
• eschiller-trac
• compass-learninglocker
• mtsinc1-trac
• jonnyx-samba
• glorpen-g_firewall
• pmuller-aws_firewall
• jethrocarr-timemachine
• ploperations-haproxy_consul
• evenup-common
• calmenergy-fail2ban
• CERNOps-bdii
• enterprisemodules-ibm_profile
• cnafsd-bdii
• olevole-memcached
• saz-memcached
• jgazeley-freeradius
• puppet-smokeping
• puppetlabs-puppetdb
• pennycoders-mesos
• puppetlabs-wordpress_app
• cloudscaling-scaleio
• CERNOps-cvmfs
• SchnWalter-happydev
• wazuh-wazuh
• echoes-strongswan
• treydock-slurm
• dhogland-splunk
• bashtoni-masq
• treydock-perfsonar
• jethrocarr-roadwarrior
• tedivm-psad
• enterprisemodules-ora_rac
• puppet-zabbix
• maany-simple_grid
• wdijkerman-zabbix
• danfoster-sitefirewall
• maxadamo-zfs_nas
• jgazeley-nagios
• maxadamo-tiny_nas
• jamesread-commonlinuxstuff
• treydock-globus
• railsdog-awsfirewall
• rogierslag-openswan
• oris-appserver
• huit-ipa
• mikegleasonjr-server
• tscopp-jss
• stesie-gluon
• tracywebtech-dofirewall
• maxadamo-galera_maxscale
• tomkrieger-remediate_install
• shearn89-toughen
• seteam-role
• maxadamo-galera_proxysql
• ffquintella-firewallmanager
• emccode-scaleio
• praekeltfoundation-docker_firewall
• treydock-gpfs
• treydock-osg

Breaking changes to this file MAY impact these 144 modules (near match):

• seteam-profile
• counsyl-sys
• dbsrinivasulu-mediawiki
• prakash007-mediawiki
• raviforge-mediawiki
• preethi-mediawiki
• webserve-mediawiki
• pia-mediawiki
• nitish741-mediawiki
• byjupv-mediakwiki
• kiranhosamani-mediawiki
• dharknes-scst
• funaccount-mediawiki
• manish1984-mediawiki
• hegdec-mediawiki
• mithilas-mediawiki
• hemantgangwar-mediawiki
• gsachar1-mediawiki
• anthomas-mediawiki
• jaysingh-mediawiki
• sunilh-mediawiki
• niksv-mediawiki
• vinaycharles-mediawiki
• pbhutani-mediawiki
• parthitraining-mediawiki
• narenv-mediawiki
• suvarnagodri-mediawiki
• 214310-mediawiki
• shantanumalik-mediawiki
• abhaysoni-mediawiki
• ravishankar1jan-mediawiki
• jmkeyes-bind
• gardouille-proxmox
• counsyl-memcached
• counsyl-redis
• sathieu-c_icap
• mmack-cfssl
• vshn-uhosting
• maestrodev-avahi
• netmanagers-dnsmasq
• netmanagers-nut
• puppetfinland-monit
• rehan-samba
• rehan-cfssl
• rtyler-jenkins
• neillturner-teamcity
• puppet-jenkins
• fuzeman-bind
• example42-xinetd
• example42-orientdb
• example42-tftp
• example42-openntpd
• example42-redis
• netmanagers-bind
• example42-monit
• example42-mysql
• example42-nginx
• concrete-nagios
• Azcender-profile
• echoes-wrappers
• soli-wrappers
• example42-libvirt
• example42-proftpd
• example42-openssh
• example42-jenkins
• example42-lighttpd
• example42-heartbeat
• example42-freeradius
• example42-sendmail
• example42-newrelic
• example42-rsync
• example42-munin
• example42-vagrant
• example42-jboss
• example42-sysklogd
• example42-clvm
• example42-multipath
• example42-rhcs
• example42-mcollective
• example42-autofs
• example42-splunk
• example42-foreman
• example42-vsftpd
• example42-puppetdashboard
• example42-ntp
• example42-samba
• example42-snmpd
• example42-nfs
• example42-dhcpd
• example42-graylog2
• example42-logstash
• example42-exim
• example42-rsyslog
• example42-postgresql
• example42-nrpe
• example42-elasticsearch
• example42-activemq
• example42-postfix
• example42-tomcat
• esakazmi-mediawiki
• enterprisemodules-easy_type
• rehan-nginx
• gururaj-mediawiki
• jethrocarr-unifi_controller
• intelliment-itlm
• jgazeley-iperf
• puppetfinland-gitdaemon
• lcgdm-voms
• example42-psick
• devopera-docommon
• jethrocarr-unifi_video
• puppetfinland-ntp
• puppetfinland-tinyproxy
• puppetfinland-aptcacherng
• puppetfinland-webserver
• puppetfinland-postfix
• puppetfinland-easy_ipa
• puppetfinland-sshd
• HEPPuppet-htcondor
• puppetfinland-mysql
• puppetfinland-snmpd
• example42-resolver
• example42-tinc
• example42-dovecot
• example42-puppetdb
• example42-puppet
• example42-apache
• tedivm-hieratic
• netmanagers-bareos
• netmanagers-bacula
• example42-openvpn
• CERNOps-fts
• puppetfinland-znc
• tykeal-gerrit
• puppetfinland-dirsrv
• puppetfinland-buildbot
• puppetfinland-bacula
• openstack-tripleo
• tscopp-bigfix
• puppetfinland-openvpn
• maestrodev-maestro_nodes
• camptocamp-pacemaker
• infnpd-creamce
• autostructure-secure_linux_cis

This module is declared in 110 of 575 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (master@3e0437b). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #931   +/-   ##
=========================================
  Coverage          ?   81.03%           
=========================================
  Files             ?       11           
  Lines             ?     1666           
  Branches          ?        0           
=========================================
  Hits              ?     1350           
  Misses            ?      316           
  Partials          ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e0437b...5536d48. Read the comment docs.