Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(IAC-966) - MODULES-10522: Add support for the --condition parameter #941

Merged
merged 6 commits into from
Dec 4, 2020
Merged

(IAC-966) - MODULES-10522: Add support for the --condition parameter #941

merged 6 commits into from
Dec 4, 2020

Conversation

adrianiurca
Copy link
Contributor

Closes: #891

@puppet-community-rangefinder
Copy link

firewall is a type

Breaking changes to this file WILL impact these 124 modules (exact match):
Breaking changes to this file MAY impact these 144 modules (near match):

This module is declared in 109 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@adrianiurca adrianiurca changed the title Add acceptance test Add acceptance test for MODULES-10522 Nov 12, 2020
@adrianiurca adrianiurca marked this pull request as ready for review December 2, 2020 11:11
@adrianiurca adrianiurca requested a review from a team as a code owner December 2, 2020 11:11
@codecov-io
Copy link

codecov-io commented Dec 2, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@c494c53). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #941   +/-   ##
=======================================
  Coverage        ?   81.22%           
=======================================
  Files           ?       11           
  Lines           ?     1678           
  Branches        ?        0           
=======================================
  Hits            ?     1363           
  Misses          ?      315           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c494c53...c8eb5c8. Read the comment docs.

@adrianiurca adrianiurca changed the title Add acceptance test for MODULES-10522 (IAC-966) - Add acceptance test for MODULES-10522 Dec 4, 2020
sanfrancrisko
sanfrancrisko suggested changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change the title and description of this PR as it is incorporating the work from #891 and adding tests to it. You could probably just take the title and description from that PR.

README.md Outdated Show resolved Hide resolved
spec/spec_helper_acceptance_local.rb Outdated Show resolved Hide resolved
lib/puppet/provider/firewall/iptables.rb Outdated Show resolved Hide resolved
adrianiurca and others added 2 commits December 4, 2020 13:57
@adrianiurca @sanfrancrisko
Update README.md
ad641f8 
Co-authored-by: sanfrancrisko <55992494+sanfrancrisko@users.noreply.github.com>
@adrianiurca @sanfrancrisko
Update lib/puppet/provider/firewall/iptables.rb
c8eb5c8 
Co-authored-by: sanfrancrisko <55992494+sanfrancrisko@users.noreply.github.com>
@adrianiurca adrianiurca changed the title (IAC-966) - Add acceptance test for MODULES-10522 (IAC-966) - MODULES-10522: Add support for the --condition parameter Dec 4, 2020
@sanfrancrisko sanfrancrisko merged commit 91058c0 into puppetlabs:main Dec 4, 2020
@adrianiurca adrianiurca mentioned this pull request Dec 4, 2020
Closed
@mattock
Copy link
Contributor

mattock commented Dec 5, 2020

Thanks everyone for finishing what I started and failed to complete in time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanfrancrisko sanfrancrisko sanfrancrisko requested changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrianiurca @codecov-io @mattock @sanfrancrisko