Add carp protocol to :proto property #945
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Gentoo using 'vrrp' sets the proto to 112 but when puppet runs it interprets 112 as 'carp' which it then corrects to 'vrrp' which is still 112. So it redoes the rule every time puppet runs. Adding carp here allows carp to be set as a valid option which removes the loop.
Codecov Report
@@ Coverage Diff @@
## master #945 +/- ##
=========================================
Coverage ? 81.03%
=========================================
Files ? 11
Lines ? 1666
Branches ? 0
=========================================
Hits ? 1350
Misses ? 316
Partials ? 0 Continue to review full report at Codecov.
|
adrianiurca
approved these changes
Oct 5, 2020
|
Hi @pellisesol, thank you for your contribution! |
apevec
pushed a commit
to redhat-openstack/rdoinfo
that referenced
this pull request
Sep 3, 2021
We had puppet-firewall pinned to commit 6e08f9678d8c4a80e96888a1a82b5fabd647efec, associated to PR [1], which is now missing from the repo. We know the commit was post-2.5.0,so let's pin to the nearest released tag (2.6.0) to minimize the risk of breaking any deployment. [1] - puppetlabs/puppetlabs-firewall#945 Change-Id: I3f54850af56ec310237ecd3727020629b8a6d679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Gentoo using 'vrrp' sets the proto to 112 but when puppet runs it interprets 112 as 'carp' which it then corrects to 'vrrp' which is still 112. So it redoes the rule every time puppet runs. Adding carp here allows carp to be set as a valid option which removes the loop.