Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(IAC-1190) add ignore_foreign when purging firewallchains #948

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Oct 9, 2020

This stops firewallchains from purging rules that do not look
like rules the module puts into place. This capability can be used
to co-exist with other firewall management solutions on the same
machine.

Improved flow in the README around setting up purging, make it
a user decision to enable, and add a pointer to ignore_foreign.

@DavidS DavidS added the feature label Oct 9, 2020
@puppet-community-rangefinder
Copy link

firewallchain is a type

Breaking changes to this file MAY impact these 21 modules (near match):

This module is declared in 108 of 575 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@bf238be). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #948   +/-   ##
=======================================
  Coverage        ?   81.18%           
=======================================
  Files           ?       11           
  Lines           ?     1669           
  Branches        ?        0           
=======================================
  Hits            ?     1355           
  Misses          ?      314           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf238be...2fe2c67. Read the comment docs.

@MikaelSmith
Copy link

This looks sufficient for our needs.

This stops `firewallchains` from purging rules that do not look
like rules the module puts into place. This capability can be used
to co-exist with other firewall management solutions on the same
machine.

Improved flow in the README around setting up purging, make it
a user decision to enable, and add a pointer to `ignore_foreign`.
@DavidS DavidS marked this pull request as ready for review October 14, 2020 09:08
@DavidS DavidS requested a review from a team as a code owner October 14, 2020 09:08
@daianamezdrea daianamezdrea merged commit 90602d1 into puppetlabs:main Oct 14, 2020
@DavidS DavidS deleted the iac-1190-ignore_foreign branch October 14, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants