Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODULES-10907] Do not remove spaces from hex string with ! #967

Merged
merged 2 commits into from
Jan 11, 2021
Merged

[MODULES-10907] Do not remove spaces from hex string with ! #967

merged 2 commits into from
Jan 11, 2021

Conversation

adrianiurca
Copy link
Contributor

No description provided.

@adrianiurca adrianiurca requested a review from a team as a code owner January 11, 2021 16:04
@puppet-community-rangefinder
Copy link

firewall is a type

Breaking changes to this file WILL impact these 123 modules (exact match):
Breaking changes to this file MAY impact these 144 modules (near match):

This module is declared in 108 of 576 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sanfrancrisko sanfrancrisko changed the title [MODULES-10907] - avoid to remove spaces outside string hex [MODULES-10907] Do not remove spaces from hex string with ! Jan 11, 2021
@sanfrancrisko sanfrancrisko merged commit 5b6a541 into puppetlabs:main Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanfrancrisko sanfrancrisko sanfrancrisko approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianiurca @sanfrancrisko