Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdksync - Remove Puppet 5 from testing and bump minimal version to 6.0.0 #972

Merged
merged 5 commits into from
Feb 18, 2021

Conversation

carabasdaniel
Copy link
Contributor

Remove Puppet 5 from testing and bump minimal version to 6.0.0
pdk version: 1.19.0.pre (47)

@codecov-io
Copy link

codecov-io commented Feb 16, 2021

Codecov Report

Merging #972 (7e62749) into main (8c1bd7b) will decrease coverage by 0.14%.
The diff coverage is 72.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   81.22%   81.07%   -0.15%     
==========================================
  Files          11       11              
  Lines        1678     1670       -8     
==========================================
- Hits         1363     1354       -9     
- Misses        315      316       +1     
Impacted Files Coverage Δ
lib/facter/ip6tables_version.rb 85.71% <ø> (ø)
lib/facter/iptables_persistent_version.rb 21.42% <ø> (ø)
lib/facter/iptables_version.rb 85.71% <ø> (ø)
lib/puppet/provider/firewall.rb 37.50% <ø> (ø)
lib/puppet/type/firewall.rb 79.59% <35.00%> (-0.34%) ⬇️
...ib/puppet/provider/firewallchain/iptables_chain.rb 36.14% <50.00%> (+0.43%) ⬆️
lib/puppet/provider/firewall/ip6tables.rb 90.12% <100.00%> (ø)
lib/puppet/provider/firewall/iptables.rb 90.18% <100.00%> (+0.05%) ⬆️
lib/puppet/type/firewallchain.rb 89.79% <100.00%> (-0.21%) ⬇️
lib/puppet/util/firewall.rb 92.06% <100.00%> (-0.13%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2da4c...7e62749. Read the comment docs.

@DavidS DavidS merged commit 20f6a93 into main Feb 18, 2021
@DavidS DavidS deleted the pdksync_remove_puppet5 branch February 18, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants