(MODULES-6876) lib/puppet/provider/firewall/iptables.rb - comments cleanup for parsing #981
Conversation
Per <https://tickets.puppetlabs.com/browse/MODULES-6876>, there are problems with parsing some iptables rules with space and quotes (specifically ones created by podman). This re-clears the comments field if it made it through earlier parsing.
|
|
|
FYI, it looks like the CI failed due to an inability to reach github.com, so I don't know what that's about... |
|
Working with my internal licensing folks. |
|
Licensing folks have approved, reopening. |
|
If anybody from the main project is reading this, is there anything I can do to help get this merged up? The most recent CI problems appears to be "can't post to Slack", which I'm pretty sure I don't have anything to do with. |
MartyEwings
changed the title
|
Hi, I tried to rebase your PR in order to merge it but it seems I don't have permissions, do you mind to rebase it ? Thank you |
|
I think the rebasing is done, please confirm? (The workflows are currently awaiting approval.) |
|
The failed checks with Rocky Linux appear to be with the Rocky Linux image, not necessarily my code? |
|
Yes, indeed, the failure is not related with your PR, thank you for your contribution! |
Per https://tickets.puppetlabs.com/browse/MODULES-6876, there are problems with parsing some iptables rules with space and quotes (specifically ones created by podman). This re-clears the comments field if it made it through earlier parsing. (This probably isn't the only or best way to solve this problem, but we need to proceed).