Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #986

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Update README.md #986

merged 1 commit into from
Apr 19, 2021

Conversation

arjenz
Copy link
Contributor

@arjenz arjenz commented Apr 15, 2021

state does not allow inversion, nor in the puppet code in this project nor in iptables rules.

`state` does not allow inversion, nor in the puppet code in this project nor in iptables rules.
@arjenz arjenz requested a review from a team as a code owner April 15, 2021 12:21
@CLAassistant
Copy link

CLAassistant commented Apr 15, 2021

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Apr 15, 2021

Codecov Report

Merging #986 (744f42e) into main (8c1bd7b) will increase coverage by 0.32%.
The diff coverage is 72.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #986      +/-   ##
==========================================
+ Coverage   81.22%   81.55%   +0.32%     
==========================================
  Files          11       11              
  Lines        1678     1670       -8     
==========================================
- Hits         1363     1362       -1     
+ Misses        315      308       -7     
Impacted Files Coverage Δ
lib/facter/ip6tables_version.rb 85.71% <ø> (ø)
lib/facter/iptables_persistent_version.rb 78.57% <ø> (+57.14%) ⬆️
lib/facter/iptables_version.rb 85.71% <ø> (ø)
lib/puppet/provider/firewall.rb 37.50% <ø> (ø)
lib/puppet/type/firewall.rb 79.59% <35.00%> (-0.34%) ⬇️
...ib/puppet/provider/firewallchain/iptables_chain.rb 36.14% <50.00%> (+0.43%) ⬆️
lib/puppet/provider/firewall/ip6tables.rb 90.12% <100.00%> (ø)
lib/puppet/provider/firewall/iptables.rb 90.18% <100.00%> (+0.05%) ⬆️
lib/puppet/type/firewallchain.rb 89.79% <100.00%> (-0.21%) ⬇️
lib/puppet/util/firewall.rb 92.06% <100.00%> (-0.13%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aa23fc...744f42e. Read the comment docs.

@david22swan david22swan merged commit d4a898b into puppetlabs:main Apr 19, 2021
@david22swan
Copy link
Member

@arjenz Thank you for bringing this to attention.
Hope to see more from you in the future.

@arjenz arjenz deleted the patch-1 branch April 19, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants