fix: parsing random_fully in ip6tables #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, failing specs look like not related to my changes: looks like case-sensitivity issue - where Puppet expects all-uppercase and iptables-save generates lower-case. |
|
Hi @scoiatael, can you rebase this PR in order to proceed to merge it? We have succeeded to solve the CI failings. |
adrianiurca
previously approved these changes
Jul 6, 2021
Looks like puppetlabs@9a4bc6a added relevant params only to iptables, not ip6tables. This results in warnings like ``` Warning: Puppet::Type::Firewall::ProviderIp6tables: Skipping unparsable iptables rule: keys (3) and values (4) count mismatch on line: -A KUBE-POSTROUTING -m comment --comment "kubernetes service traffic requiring SNAT" -j MASQUERADE --random-fully ```
|
|
adrianiurca
approved these changes
Jul 6, 2021
|
Hey @scoiatael, thank you for your contribution! kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like 9a4bc6a added relevant params only to iptables, not ip6tables.
This results in warnings like
Also, I'm not quite sure whether boolean params should be converted to ruby types at some point.
If that's the case, this test should be fixed - but I have no idea how.