Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sles-15: mac_source is downcased by iptables #997

Merged
merged 1 commit into from
Jul 5, 2021
Merged

sles-15: mac_source is downcased by iptables #997

merged 1 commit into from
Jul 5, 2021

Conversation

adrianiurca
Copy link
Contributor

@adrianiurca adrianiurca commented Jul 5, 2021 •
edited
Loading

It looks that mac_source parameter cannot be applied idempotently on sles-15 iptables downcase the value.
For example: '0A:1B:3C:4D:5E:6F' --> '0a:1b:3c:4d:5e:6f'. And puppet triggers this as Properties changed - updating rule. So this causes idempotency issues.

Notice: Compiled catalog for litmus-0bf65b80828b158e.c.ia-content.internal in environment production in 0.08 seconds
Notice: /Stage[main]/Main/Firewall[610 - test]/mac_source: mac_source changed '0a:1b:3c:4d:5e:6f' to '0A:1B:3C:4D:5E:6F'
Notice: Firewall[610 - test](provider=iptables): Properties changed - updating rule
Notice: Applied catalog in 0.14 seconds

@adrianiurca adrianiurca requested a review from a team as a code owner July 5, 2021 10:35
@puppet-community-rangefinder
Copy link

firewall is a type

Breaking changes to this file WILL impact these 121 modules (exact match):
Breaking changes to this file MAY impact these 143 modules (near match):

This module is declared in 108 of 576 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@adrianiurca adrianiurca changed the title sles-12/15: mac_source is downcased by iptables sles-15: mac_source is downcased by iptables Jul 5, 2021
@carabasdaniel carabasdaniel merged commit 208abd6 into main Jul 5, 2021
@carabasdaniel carabasdaniel deleted the mac_source-idempotency branch July 5, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carabasdaniel carabasdaniel carabasdaniel approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrianiurca @carabasdaniel