Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-iis
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4.3.1
Choose a base ref
...
head repository: puppetlabs/puppetlabs-iis
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 4.3.2
Choose a head ref
  • 18 commits
  • 12 files changed
  • 7 contributors

Commits on Mar 27, 2018

  1. (IMAGES-795) 2008r2 template failing PowerShell module tests

    The newest image for Windows 2008r2 is exhibiting different behavior
    for loading .NET assemblies than we have seen in the past. The
    System.Core assembly is not loaded into the PowerShell host process by
    default any longer. This causes the init.ps1 script in the module to
    to fail to start a Pipe Server to receive PowerShell scripts to be
    executed. This change always attempts to load the System.Core
    assembly prior to creating the pipe server object. Explicity loading the
    assembly fixes the issue and the newest image becomes usable again. This
    fix is also require to fix any moduels that depend on the PowerShell
    exec provider working properly.
    glennsarti committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    e9220a3 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #164 from glennsarti/IMAGES-795-fix-2008r2

    (IMAGES-795) 2008r2 template failing PowerShell module tests
    RandomNoun7 authored Mar 27, 2018
    Configuration menu
    Copy the full SHA
    d204ce5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    537edce View commit details
    Browse the repository at this point in the history
  4. Merge pull request #165 from puppetlabs/revert-164-IMAGES-795-fix-2008r2

    Revert "(IMAGES-795) 2008r2 template failing PowerShell module tests"
    Iristyle authored Mar 27, 2018
    Configuration menu
    Copy the full SHA
    a15c875 View commit details
    Browse the repository at this point in the history
  5. (MODULES-6928) Fix Pipe Server on Win 2008r2

    The newest image for Windows 2008r2 is exhibiting different behavior
    for loading .NET assemblies than we have seen in the past. The
    System.Core assembly is not loaded into the PowerShell host process by
    default any longer. This causes the init.ps1 script in the module to
    to fail to start a Pipe Server to receive PowerShell scripts to be
    executed. This change always attempts to load the System.Core
    assembly prior to creating the pipe server object. Explicity loading the
    assembly fixes the issue and the newest image becomes usable again.
    RandomNoun7 committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    385e060 View commit details
    Browse the repository at this point in the history
  6. Merge pull request #166 from RandomNoun7/tickets/master/MODULES-6928-…

    …fix-pipe-server-on-win2008r2
    
    (MODULES-6928) Fix Pipe Server on Win 2008r2
    michaeltlombardi authored Mar 27, 2018
    Configuration menu
    Copy the full SHA
    686d103 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2018

  1. (MODULES-6869) add a test for unicode site name

    Add a test for UTF-8 site_name that expects failure such that when we fix
    UTF-8 characters in IIS we'll have a working acceptance test.
    Erick Banks committed May 1, 2018
    Configuration menu
    Copy the full SHA
    ac54c61 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2018

  1. Merge pull request #168 from ThoughtCrhyme/MODULES-6869

    (MODULES-6869) add a test for unicode site name
    Iristyle authored May 2, 2018
    Configuration menu
    Copy the full SHA
    1f990aa View commit details
    Browse the repository at this point in the history

Commits on May 9, 2018

  1. Configuration menu
    Copy the full SHA
    7663c23 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2018

  1. Merge pull request #169 from RandomNoun7/maint/master/update-metadata…

    …-description
    
    (MAINT) Update Metadata Description to Match Supported Platforms.
    jpogran authored May 10, 2018
    Configuration menu
    Copy the full SHA
    375d2bf View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2018

  1. (MAINT) Fix Powershell Manager Test

    As per MODULES-7033, this change fixes a test in powershell_manager_spec
    that causes the CI pipeline to erroneously fail on some test runs
    because of a race condition in the calls to Process.kill(). Refer to
    commit 94865de in puppetlabs-powershell for the corresponding fix in
    that module.
    RandomNoun7 committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    e90a8c7 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #173 from RandomNoun7/maint/master/fix-powershellm…

    …anager-test
    
    (MAINT) Fix Powershell Manager Test
    Erick Banks authored Jun 12, 2018
    Configuration menu
    Copy the full SHA
    19f6f14 View commit details
    Browse the repository at this point in the history
  3. (MAINT) Remove unnecessary rake tasks

    Erick Banks committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    be9b0f4 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #172 from ThoughtCrhyme/MAINT

    (MAINT) Remove unnecessary rake tasks
    RandomNoun7 authored Jun 12, 2018
    Configuration menu
    Copy the full SHA
    aa1baa2 View commit details
    Browse the repository at this point in the history
  5. (MODULES-7173) Cannot Start IIS Site with Port 443

    This change fixese a bug where a site bound to port 443 in the binding
    information hash could not be started. Before version 4.3.0 all sites
    were created on Port 80, and only later in the configuration process
    would they be given a port binding to port 443 and the https protocol
    enabled on the site. After 4.3.0, the port binding was passed to the
    New-Website cmdlet by default as a way to avoid conflicts on port 80.
    Unfortunately, the https protocol was not enabled by default if the port
    binding was 443. When the site was started, as it always is by default,
    IIS would throw an error because a site bound to port 443 is not allowed
    to start if the HTTPS protocol is not enabled.
    
    This change detects when the HTTPS protocol has been specified as
    enabled, or when the user has specified port 443 as the port binding. In
    reality checking for both is probably not needed as they are mutual
    requirements, but it costs little to do the check, so both are checked.
    
    This change also incorporates additional automated testing to ensure
    that future releases do not break HTTPS sites.
    
    This change also modifies the test for creating an SSL enabled site. The
    test now does three puppet runs to ensure that the site is in its final
    configured state and then tests the properties of the site. Only if
    there are still changes being reported by puppet on the third run is
    there a real idempotency bug we care about at the moment. MODULES-5561
    is tracking an idempotency issue that is very similar, and when that
    ticket is signed off we will most likely be able to return this test to
    running using the normal it_behaves_like 'an idempotent resource'
    helper.
    RandomNoun7 committed Jun 12, 2018
    Configuration menu
    Copy the full SHA
    00fbf1e View commit details
    Browse the repository at this point in the history
  6. Merge pull request #171 from RandomNoun7/tickets/master/MODULES-7173-…

    …cannot-start-https-website
    
    (MODULES-7173) Cannot Start IIS Site with Port 443
    Erick Banks authored Jun 12, 2018
    Configuration menu
    Copy the full SHA
    b2c09c1 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2018

  1. Configuration menu
    Copy the full SHA
    acc2294 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #174 from RandomNoun7/tickets/master/MODULES-7276-…

    …release-prep-4.3.2
    
    (MODULES-7276) Release Prep 4.3.2
    michaeltlombardi authored Jun 13, 2018
    Configuration menu
    Copy the full SHA
    e2728ac View commit details
    Browse the repository at this point in the history
Loading