(FM 8426) replace vendored code with pwshlib dependency #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
=========================================
- Coverage 60.56% 53.6% -6.96%
=========================================
Files 28 24 -4
Lines 1529 1263 -266
=========================================
- Hits 926 677 -249
+ Misses 603 586 -17
Continue to review full report at Codecov.
|
michaeltlombardi
previously approved these changes
Dec 6, 2019
|
Waiting on litmusify |
david22swan
changed the title
added 3 commits
December 19, 2019 12:14
This commit adds the pwshlib module / ruby-pwsh gem as a dependency, updating the development gems list in the Gemfile, the dependencies in the metadata, and the fixtures list. This will enable the module to depend on the updted library code from the ruby-pwsh gem and pwshlib.
Prior to this commit the PowerShell module providers depended on a vendored version of the PowerShell code manager library in the PuppetX namespace. This commit updates the providers and their tests to leverage the ruby-pwsh gem from the pwshlib Puppet module instead. This reduces the amount of maintenance required and simplifies the code base.
david22swan
changed the title
DavidS
approved these changes
Dec 19, 2019
DavidS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.