Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FM-8195) Convert to Litmus #249

Merged
merged 3 commits into from
Dec 19, 2019
Merged

(FM-8195) Convert to Litmus #249

merged 3 commits into from
Dec 19, 2019

Conversation

florindragos
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 10, 2019

Codecov Report

Merging #249 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   60.56%   60.69%   +0.13%     
==========================================
  Files          28       28              
  Lines        1529     1529              
==========================================
+ Hits          926      928       +2     
+ Misses        603      601       -2
Impacted Files Coverage Δ
lib/puppet_x/puppetlabs/iis/iis_version.rb 100% <0%> (+3.33%) ⬆️
lib/puppet_x/puppetlabs/iis/powershell_common.rb 100% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7835dd5...5eb1189. Read the comment docs.

@michaeltlombardi
Copy link
Contributor

The second commit in this PR splits the acceptance tests for appveyor into two suites using tags; this is to ensure that the tests can actually complete in under 60m consistently, enabling them to run on each PR.

A future set of commits should refactor the test suite properly to shell out to bolt less frequently, reduce duplcate tests, and otherwise seek speed improvements so we can reconsolidate the CI setup.

Copy link
Contributor

@DavidS DavidS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test suite is cursed, but at least it's passing.

Happy Holidays.

@DavidS DavidS merged commit b114528 into puppetlabs:master Dec 19, 2019
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.69%. Comparing base (01968e8) to head (8744fde).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   60.56%   60.69%   +0.13%     
==========================================
  Files          28       28              
  Lines        1529     1529              
==========================================
+ Hits          926      928       +2     
+ Misses        603      601       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants