(MODULES-10361) sort https bindings first #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pillarsdotnet
force-pushed
the
MODULES-10361
branch
28 times, most recently
from
425fe9e
to
1e079fa
Compare
glennsarti
reviewed
Dec 31, 2019
glennsarti
reviewed
Dec 31, 2019
pillarsdotnet
force-pushed
the
MODULES-10361
branch
3 times, most recently
from
8d8bfe7
to
ef3249b
Compare
pillarsdotnet
force-pushed
the
MODULES-10361
branch
3 times, most recently
from
26a679e
to
90583df
Compare
|
Okay, now I'm mystified all over again. Declaring an http binding before an https binding fails in local testing, but succeeds in appveyor. |
pillarsdotnet
force-pushed
the
MODULES-10361
branch
from
41b3059
to
f58bf24
Compare
|
Sorting bindings on resource create/update doesn't solve my problem. Trying again within instances and prefetch methods. |
|
That fails, too. I don't understand the failure, though. Help, anyone? |
pillarsdotnet
force-pushed
the
MODULES-10361
branch
from
f58bf24
to
b8e7b1e
Compare
|
@pillarsdotnet What version of IIS and OS are you testing on locally vs Appveyor. And don't forget you can temporarily RDP into an appveyor worker |
pillarsdotnet
force-pushed
the
MODULES-10361
branch
from
b8e7b1e
to
1895c93
Compare
pillarsdotnet
force-pushed
the
MODULES-10361
branch
from
1895c93
to
2c665f6
Compare
|
I've noted my versions in the puppetlabs ticket, but thanks for the appveyor tip! |
|
The latest commit resolves the problem in local testing. I'm not sure how to replicate that in Appveyor. |
DavidS
approved these changes
Jan 6, 2020
DavidS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: MODULES-10361
When creating an
iis_siteresource, if non-ssl bindings come before ssl bindings, resource creation fails with an error similar to the following:This patch sorts
httpsbindings before non-httpsbindings.