(MODULES-10362) handle authenticationinfo consistently #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pillarsdotnet
force-pushed
the
MODULES-10362
branch
4 times, most recently
from
2b8b1ba
to
d7df83f
Compare
pillarsdotnet
force-pushed
the
MODULES-10362
branch
10 times, most recently
from
316d7e8
to
24b76f8
Compare
DavidS
approved these changes
Jan 6, 2020
DavidS
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: MODULES-10362
The handling of the
authenticationinfofield is inconsistent. Within theiis_siteresource, keys are checked for validity.Within the
iis_applicationresource, theinsync?function is redefined to ignore element ordering.Both functionalities should be enforced in both places.