Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-10702) Make certificatestorename case insensitive. #280

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

nicolasvan
Copy link
Contributor

This makes sure that puppet run are idempotent on servers on which the Powershell WebAdministration module shows inconsistent casing for the certificate store names.

ls IIS:\SslBindings\ | ft -AutoSize

IP Address  Port    Host Name             Store  Sites
----------  ----    ---------             -----  -----
            443     somewebsite.com       My    somewebsite.com
            443     someotherwebsite.com  MY    someotherwebsite.com
0.0.0.0     8172                          MY

@nicolasvan nicolasvan requested a review from a team as a code owner June 12, 2020 15:47
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #280 into master will increase coverage by 0.10%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #280      +/-   ##
==========================================
+ Coverage   55.45%   55.55%   +0.10%     
==========================================
  Files          26       26              
  Lines        1311     1314       +3     
==========================================
+ Hits          727      730       +3     
  Misses        584      584              
Impacted Files Coverage Δ
lib/puppet/provider/iis_site/webadministration.rb 26.61% <0.00%> (-0.22%) ⬇️
lib/puppet/type/iis_site.rb 82.91% <100.00%> (+0.17%) ⬆️
lib/puppet_x/puppetlabs/iis/iis_version.rb 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cae9e2...51d4225. Read the comment docs.

@david22swan david22swan merged commit 689f547 into puppetlabs:master Jun 17, 2020
@nicolasvan nicolasvan deleted the upcase_certificatestorename branch June 18, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants