Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make iis application physicalpath optional #282

Merged
merged 2 commits into from
Jun 26, 2020
Merged

Make iis application physicalpath optional #282

merged 2 commits into from
Jun 26, 2020

Conversation

adrianiurca
Copy link
Contributor

@adrianiurca adrianiurca commented Jun 26, 2020

Opened this PR to add acceptance test for #279:

New-WebApplication -PhysicalPath is not a required parameter.
Allowing iis_application without setting physicalpath allows other systems to change physicalpath without puppet undoing the changes.

Closes: #279

nicolasvan and others added 2 commits June 10, 2020 14:26
New-WebApplication -PhysicalPath is not a required parameter.
Allowing it to not be set allows other systems to change it whithout puppet undoing the changes.
(e.g. We use this when deploying web apps via Octopus Deploy)
@adrianiurca adrianiurca requested a review from a team as a code owner June 26, 2020 09:00
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2020

Codecov Report

Merging #282 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #282      +/-   ##
==========================================
+ Coverage   55.45%   55.52%   +0.06%     
==========================================
  Files          26       26              
  Lines        1311     1313       +2     
==========================================
+ Hits          727      729       +2     
  Misses        584      584              
Impacted Files Coverage Δ
...ppet/provider/iis_application/webadministration.rb 59.64% <ø> (-0.36%) ⬇️
lib/puppet/provider/iis_site/webadministration.rb 26.61% <0.00%> (-0.22%) ⬇️
lib/puppet/type/iis_site.rb 82.91% <0.00%> (+0.17%) ⬆️
lib/puppet_x/puppetlabs/iis/iis_version.rb 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cae9e2...a172c75. Read the comment docs.

@adrianiurca
Copy link
Contributor Author

The release checks tests are passing:
`Finished in 23 minutes 2 seconds (files took 11.91 seconds to load)
140 examples, 0 failures, 1 pending

WARNING: Using the raise_error matcher without providing a specific error or message risks false positives, since raise_error will match when Ruby raises a NoMethodError, NameError or ArgumentError, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was #<RuntimeError: apply manifest failed
` puppet apply manifest_20200624_3732_1chijyd.pp --trace --deta...et in environment production in 0.20 seconds

====== End output of failed Puppet apply ======

. Instead consider providing a specific error class or message. This message can be suppressed by setting: RSpec::Expectations.configuration.on_potential_false_positives = :nothing. Called from /root/puppetlabs-iis/spec/acceptance/iis_unicode_site_spec.rb:25:in block (4 levels) in <top (required)>'. WARNING: Using the raise_errormatcher without providing a specific error or message risks false positives, sinceraise_errorwill match when Ruby raises aNoMethodError, NameErrororArgumentError, potentially allowing the expectation to pass without even executing the method you are intending to call. Actual error raised was #<NoMethodError: undefined method assert_match' for #RSpec::ExampleGroups::IisSite_2::WhenConfiguringAWebsite::WithRequiredParametersAndUTF8SiteName:0x00007fbca1a81780>. Instead consider providing a specific error class or message. This message can be suppressed by setting: RSpec::Expectations.configuration.on_potential_false_positives = :nothing. Called from /root/puppetlabs-iis/spec/acceptance/iis_unicode_site_spec.rb:38:in block (4 levels) in <top (required)>'. pid 3732 exit 0 Successful on 4 nodes: ["athletic-simile.delivery.puppetlabs.net, win-2016-core-x86_64", "ruddy-telescope.delivery.puppetlabs.net, win-2019-core-x86_64", "memorial-drunk.delivery.puppetlabs.net, win-2008r2-x86_64", "brazen-washer.delivery.puppetlabs.net, win-2012r2-x86_64"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants