Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MODULES-10884 Allow a UNC path as the physical path of a web site #301

Merged
merged 1 commit into from
Dec 7, 2020
Merged

MODULES-10884 Allow a UNC path as the physical path of a web site #301

merged 1 commit into from
Dec 7, 2020

Conversation

palintir
Copy link
Contributor

… as the physical path of a web site

@palintir
MODULES-10884 Allow a UNC path to be specified as the physical path o…
ee64d58 
…f a web site

Added an additional regex when validating a site's physicalpath to allow format: \\server.fqdn\share\location
@palintir palintir requested a review from a team as a code owner November 30, 2020 13:59
@puppet-community-rangefinder
Copy link

iis_site is a type

Breaking changes to this file WILL impact these 1 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 4 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@carabasdaniel carabasdaniel changed the title MODULES-10884 Allow a UNC path to be specified as the physical path o… MODULES-10884 Allow a UNC path as the physical path of a web site Dec 7, 2020
carabasdaniel
carabasdaniel approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@carabasdaniel carabasdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@carabasdaniel carabasdaniel merged commit 4f2a572 into puppetlabs:main Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carabasdaniel carabasdaniel carabasdaniel approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palintir @carabasdaniel