Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-9656) - Enable using 0 for application pool settings #321

Merged
merged 2 commits into from
May 6, 2021

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented May 5, 2021

Currently is it not possible to set the following to 0.

  • cpu_limit
  • max_processes
  • restart_memory_limit
  • restart_private_memory_limit
  • restart_requests_limit

This PR adds a new property called whole number. A whole number can be any integer including 0 and applies it to the above.

@pmcmaw pmcmaw requested a review from a team as a code owner May 5, 2021 14:35
@puppet-community-rangefinder
Copy link

iis_application_pool is a type

Breaking changes to this file WILL impact these 1 modules (exact match):
Breaking changes to this file MAY impact these 1 modules (near match):

This module is declared in 4 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@pmcmaw
Copy link
Contributor Author

pmcmaw commented May 5, 2021

I have tested this change manually alongside the automated tests I have added.
I used the following manifest:

     iis_application_pool { 'this_pool':
        ensure                       => 'present',
        state                        => 'started',
        cpu_limit                    => '0',
        max_processes                => '0',
        restart_memory_limit         => '0',
        restart_private_memory_limit => '0',
        restart_requests_limit       => '0'
}

Screen Shot 2021-05-05 at 5 10 25 PM

In the screenshot above you can see the values being set to 0 without any errors.

@pmcmaw pmcmaw added the bugfix label May 6, 2021
Copy link
Contributor

@michaeltlombardi michaeltlombardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@michaeltlombardi michaeltlombardi merged commit 8d02763 into puppetlabs:main May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants