Correct error handling in require ruby-pwsh #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
michaeltlombardi
previously approved these changes
May 27, 2021
|
@benningm - if you could sign the CLA, we'd love to merge this PR! |
The error handling around the require for 'ruby-pwsh' tries to rescue with nil, but does not pass an argument to rescue which by default will rescue only StandardError. In this case it should rescue the LoadError which is not a StandardError: LoadError.is_a? StandardError => false
benningm
force-pushed
the
fix-ruby-pwsh-not-available-2
branch
from
15bef5c
to
1ad21a0
Compare
|
@benningm, as we promised, I'll push the merge button ! Thank you for your contribution ! Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error handling around the require for 'ruby-pwsh'
tries to rescue with nil, but does not pass an argument
to rescue which by default will rescue only StandardError.
In this case it should rescue the LoadError which is not
a StandardError:
LoadError.is_a? StandardError => false