MODULES-11188: trim physicalpath for iis_application resource #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iis_application is a typethat may have no external impact to Forge modules. This module is declared in 4 of 578 indexed public
|
|
@LukasAud is going to be pushing this PR through along with some new changes. |
|
I have tested the latest change with the code supplied in the Jira ticket and everything works as expected now. |
LukasAud
force-pushed
the
modules-11188
branch
3 times, most recently
from
55991f9
to
b850189
Compare
david22swan
reviewed
Mar 10, 2022
Prior to this commit, there was an attempt to fix an issue where puppet could not handle a trailing '/' at the end of a physicalpath. While it stopped users from creating resources with trailing '/', it did not fix existing IIS entities that already had the trailing '/'. This commit aims to complement the previous code by removing trailing '/' in physicalpaths for existing resources.
Prior to this commit there were some unit tests that would fail due to the additional checks inserted in the latest fix. Some of the previous code would also not work as intended and lint was throwing warnings at some formatting choices made. This commit aims to provide a number of small fixes to deal with both, lint warnings and small errors in previous code that would make unit tests fail.
Prior to this commit several fixes were implemented to deal with the problem described in the JIRA ticket MODULES-11188. As a result of those changes, the behaviour of the module regarding physicalpaths was slighly altered. This commit aims to update the README file to inform users about the previously existing issue and the measures that the module will take to deal with it.
david22swan
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.