(MODULES-11188) Fix physicalPath on apps and sites #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit it looks like we'd chosen the incorrect property to pull back from the iis config. PhysicalPath != physicalPath and the former was behaving differently between the app and site resources. This commit standardises on physicalPath which returns the correct value for both app and site resources. For clarity, physicalPath returns a string which we can directly manipulate if required.
chelnak
force-pushed
the
MODULES-11188-physical_path_fixes
branch
from
35cbcb0
to
4ab8f4b
Compare
david22swan
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Prior to this PR it looks like we'd chosen the incorrect property to pull back from the iis config. It turns out that
PhysicalPath!=physicalPathand the former was behaving differently between the app and site resources.What has changed?
This PR standardises on physicalPath which returns the correct value for both app and site resources. For clarity, physicalPath returns a string which we can directly manipulate if required.