New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Apache Example #1

Merged
merged 1 commit into from Jan 19, 2017

Conversation

Projects
None yet
3 participants
@ipcrm

ipcrm commented Aug 19, 2016

Added apache example that will work for Ubuntu or CentOS (defaults to Ubuntu). In order to use it with CentOS you do need to pass both the from ("centos:7") option as well as cmd ("/usr/sbin/httpd,-DFOREGROUND")

ipcrm
Adding Apache Example
Added apache example that will work for Ubuntu or RHEL (defaults
to Ubuntu).  In order to use it with RHEL you do need to pass both
the `from` option as well as `cmd` ("/usr/sbin/httpd,-DFOREGROUND")
@@ -0,0 +1,15 @@
class { '::apache':
default_vhost => false,

This comment has been minimized.

@sheenaajay

sheenaajay Jan 19, 2017

Contributor

Modify from class { '::apache': to class { 'apache':

@sheenaajay

sheenaajay Jan 19, 2017

Contributor

Modify from class { '::apache': to class { 'apache':

This comment has been minimized.

@garethr

garethr Jan 19, 2017

Contributor

@sheenaajay the format with :: is more correct. This avoids issues with finding classes at other parts of the hierarchy.

@garethr

garethr Jan 19, 2017

Contributor

@sheenaajay the format with :: is more correct. This avoids issues with finding classes at other parts of the hierarchy.

This comment has been minimized.

@sheenaajay

sheenaajay Jan 19, 2017

Contributor

@ipcrm @garethr .Thanks.Will merge the changes.Good to go

@sheenaajay

sheenaajay Jan 19, 2017

Contributor

@ipcrm @garethr .Thanks.Will merge the changes.Good to go

@sheenaajay

This comment has been minimized.

Show comment
Hide comment
@sheenaajay

sheenaajay Jan 19, 2017

Contributor

@ipcrm Thanks Matt for the contribution. Apologize for the delay.Please find the minor comments on the PR.

Contributor

sheenaajay commented Jan 19, 2017

@ipcrm Thanks Matt for the contribution. Apologize for the delay.Please find the minor comments on the PR.

@sheenaajay sheenaajay merged commit 9150ef1 into puppetlabs:master Jan 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment