Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-inifile
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.0.3
Choose a base ref
...
head repository: puppetlabs/puppetlabs-inifile
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.9.0
Choose a head ref
  • 16 commits
  • 9 files changed
  • 3 contributors

Commits on Sep 29, 2012

  1. Allow values with spaces to be parsed and set

    Previously, the following stanza would fail as a result of the
    ini_setting type not being able to parse spaces in setting values.
    
      ini_setting { 'main_config_version':
        ensure  => present,
        path    => '/etc/puppetlabs/puppet/puppet.conf',
        section => 'main',
        setting => 'config_version',
        value   => '/etc/puppetlabs/puppet/config_version.sh $environment',
      }
    
    This commit modifes the SETTING_REGEX to account for spaces in setting values.
    reidmv committed Sep 29, 2012
    Configuration menu
    Copy the full SHA
    3829e20 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2012

  1. Merge pull request #15 from reidmv/bug/master/spaces

    Cool, thanks!
    cprice404 committed Oct 1, 2012
    Configuration menu
    Copy the full SHA
    6d3e6a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2012

  1. Make ruby provider a better parent.

    In order to allow the provider to be a parent for
    other providers, I have implemented the following
    methods: section, setting, file_path, separator so
    that they can be overridden by child providers and
    decouple this provider from its type.
    Dan Bode committed Oct 3, 2012
    Configuration menu
    Copy the full SHA
    1564c47 View commit details
    Browse the repository at this point in the history
  2. Make value a property

    This commit converts value to a property so that it
    can be managed and modified when a file already has
    a value set.
    
    It was previously treating the line creation state
    the same as the update case, which is not in
    alignment with Puppet's model.
    Dan Bode committed Oct 3, 2012
    Configuration menu
    Copy the full SHA
    cbc90d3 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #16 from bodepd/master

    changes for child provider usage
    cprice404 committed Oct 3, 2012
    Configuration menu
    Copy the full SHA
    842b2f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2012

  1. Add support for removing lines

    This commit adds the ability to ensure that lines are absent.
    Dan Bode committed Oct 11, 2012
    Configuration menu
    Copy the full SHA
    1106d70 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2012

  1. Minor tweaks to handling of removing settings

    This commit makes some minor changes to how we handle removing
    settings.  In particular, it updates all of the line numbers
    of the various 'section' objects to correspond to the new
    state of the world based on the removal of a line that appeared
    before them.
    
    Also adds one more test related to setting removal.
    cprice404 committed Oct 17, 2012
    2 Configuration menu
    Copy the full SHA
    cda30a6 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #18 from cprice-puppet/feature/master/tweaks-to-se…

    …tting-removal
    
    Feature/master/tweaks to setting removal
    cprice404 committed Oct 17, 2012
    Configuration menu
    Copy the full SHA
    a5eebcf View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2012

  1. Respect indentation / spacing for existing sections and settings

    This commit adds some cosmetic functionality.  The main two
    improvements are:
    
    * We'll now pay attention to indentation within existing
      sections, and when we write new settings or update
      existing ones, we'll match the existing indentation.
    
    * When modifying existing settings, the regex now captures
      a greater portion of the original line and preserves it.
      Basically, the original whitespacing in the line should
      remain intact and only the value should be modified.
    cprice404 committed Oct 20, 2012
    Configuration menu
    Copy the full SHA
    c2c26de View commit details
    Browse the repository at this point in the history
  2. Better handling of whitespace lines at ends of sections

    This is another bit of cosmetic functionality; prior to
    this commit, when adding a new setting to a section, we'd
    write it on the very last line before the next section,
    even if there was a chunk of trailing whitespace lines
    at the end of the existing section.  This was functional,
    but the output was not always particularly pleasant for
    human consumption.
    
    This commit tweaks things so that we insert new settings
    just before the final chunk of whitespace lines in an
    existing section.  This keeps things a bit cleaner.
    cprice404 committed Oct 20, 2012
    Configuration menu
    Copy the full SHA
    845fa70 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2012

  1. Configuration menu
    Copy the full SHA
    e517148 View commit details
    Browse the repository at this point in the history
  2. Refactor to clarify implementation of save

    The `save` method was previously relying on some really
    specific implementation details of the `section` class
    (when the start/end_line would be nil, etc.).  This made
    the code a bit hard to follow.
    
    This commit introduces a few utility methods in the
    `section` class (`is_new_section?`, `is_global?`), and
    refactors the `save` method to use them... this makes
    the logic a little easier to follow and should hopefully
    make it easier to maintain.
    cprice404 committed Oct 21, 2012
    Configuration menu
    Copy the full SHA
    f0d443f View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2012

  1. Merge pull request #19 from cprice-puppet/feature/master/use-existing…

    …-indentation
    
    Feature/master/use existing indentation
    cprice404 committed Oct 22, 2012
    Configuration menu
    Copy the full SHA
    8a0d1fa View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2012

  1. Add detection for commented versions of settings

    This commit adds support for detecting commented versions of
    settings in an existing version of an inifile.  If you are
    setting a value for a setting that isn't currently set
    in the file, but a commented version is found, then we
    add the new setting immediately following the commented
    version, rather than at the end of the section.
    cprice404 committed Oct 27, 2012
    Configuration menu
    Copy the full SHA
    a45ab65 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #20 from cprice-puppet/feature/master/detect-comme…

    …nted-settings
    
    Add detection for commented versions of settings
    cprice404 committed Oct 27, 2012
    Configuration menu
    Copy the full SHA
    85afa27 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2012

  1. Configuration menu
    Copy the full SHA
    6a53230 View commit details
    Browse the repository at this point in the history
Loading