-
Notifications
You must be signed in to change notification settings - Fork 177
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-inifile
base: 0.0.3
head repository: puppetlabs/puppetlabs-inifile
compare: 0.9.0
- 16 commits
- 9 files changed
- 3 contributors
Commits on Sep 29, 2012
-
Allow values with spaces to be parsed and set
Previously, the following stanza would fail as a result of the ini_setting type not being able to parse spaces in setting values. ini_setting { 'main_config_version': ensure => present, path => '/etc/puppetlabs/puppet/puppet.conf', section => 'main', setting => 'config_version', value => '/etc/puppetlabs/puppet/config_version.sh $environment', } This commit modifes the SETTING_REGEX to account for spaces in setting values.Configuration menu - View commit details
-
Copy full SHA for 3829e20 - Browse repository at this point
Copy the full SHA 3829e20View commit details
Commits on Oct 1, 2012
-
Configuration menu - View commit details
-
Copy full SHA for 6d3e6a1 - Browse repository at this point
Copy the full SHA 6d3e6a1View commit details
Commits on Oct 3, 2012
-
Make ruby provider a better parent.
In order to allow the provider to be a parent for other providers, I have implemented the following methods: section, setting, file_path, separator so that they can be overridden by child providers and decouple this provider from its type.
Dan Bode committedOct 3, 2012 Configuration menu - View commit details
-
Copy full SHA for 1564c47 - Browse repository at this point
Copy the full SHA 1564c47View commit details -
This commit converts value to a property so that it can be managed and modified when a file already has a value set. It was previously treating the line creation state the same as the update case, which is not in alignment with Puppet's model.
Dan Bode committedOct 3, 2012 Configuration menu - View commit details
-
Copy full SHA for cbc90d3 - Browse repository at this point
Copy the full SHA cbc90d3View commit details -
Merge pull request #16 from bodepd/master
changes for child provider usage
Configuration menu - View commit details
-
Copy full SHA for 842b2f0 - Browse repository at this point
Copy the full SHA 842b2f0View commit details
Commits on Oct 11, 2012
-
Add support for removing lines
This commit adds the ability to ensure that lines are absent.
Dan Bode committedOct 11, 2012 Configuration menu - View commit details
-
Copy full SHA for 1106d70 - Browse repository at this point
Copy the full SHA 1106d70View commit details
Commits on Oct 17, 2012
-
Minor tweaks to handling of removing settings
This commit makes some minor changes to how we handle removing settings. In particular, it updates all of the line numbers of the various 'section' objects to correspond to the new state of the world based on the removal of a line that appeared before them. Also adds one more test related to setting removal.
2Configuration menu - View commit details
-
Copy full SHA for cda30a6 - Browse repository at this point
Copy the full SHA cda30a6View commit details -
Merge pull request #18 from cprice-puppet/feature/master/tweaks-to-se…
…tting-removal Feature/master/tweaks to setting removal
Configuration menu - View commit details
-
Copy full SHA for a5eebcf - Browse repository at this point
Copy the full SHA a5eebcfView commit details
Commits on Oct 20, 2012
-
Respect indentation / spacing for existing sections and settings
This commit adds some cosmetic functionality. The main two improvements are: * We'll now pay attention to indentation within existing sections, and when we write new settings or update existing ones, we'll match the existing indentation. * When modifying existing settings, the regex now captures a greater portion of the original line and preserves it. Basically, the original whitespacing in the line should remain intact and only the value should be modified.
Configuration menu - View commit details
-
Copy full SHA for c2c26de - Browse repository at this point
Copy the full SHA c2c26deView commit details -
Better handling of whitespace lines at ends of sections
This is another bit of cosmetic functionality; prior to this commit, when adding a new setting to a section, we'd write it on the very last line before the next section, even if there was a chunk of trailing whitespace lines at the end of the existing section. This was functional, but the output was not always particularly pleasant for human consumption. This commit tweaks things so that we insert new settings just before the final chunk of whitespace lines in an existing section. This keeps things a bit cleaner.
Configuration menu - View commit details
-
Copy full SHA for 845fa70 - Browse repository at this point
Copy the full SHA 845fa70View commit details
Commits on Oct 21, 2012
-
Configuration menu - View commit details
-
Copy full SHA for e517148 - Browse repository at this point
Copy the full SHA e517148View commit details -
Refactor to clarify implementation of
saveThe `save` method was previously relying on some really specific implementation details of the `section` class (when the start/end_line would be nil, etc.). This made the code a bit hard to follow. This commit introduces a few utility methods in the `section` class (`is_new_section?`, `is_global?`), and refactors the `save` method to use them... this makes the logic a little easier to follow and should hopefully make it easier to maintain.
Configuration menu - View commit details
-
Copy full SHA for f0d443f - Browse repository at this point
Copy the full SHA f0d443fView commit details
Commits on Oct 22, 2012
-
Merge pull request #19 from cprice-puppet/feature/master/use-existing…
…-indentation Feature/master/use existing indentation
Configuration menu - View commit details
-
Copy full SHA for 8a0d1fa - Browse repository at this point
Copy the full SHA 8a0d1faView commit details
Commits on Oct 27, 2012
-
Add detection for commented versions of settings
This commit adds support for detecting commented versions of settings in an existing version of an inifile. If you are setting a value for a setting that isn't currently set in the file, but a commented version is found, then we add the new setting immediately following the commented version, rather than at the end of the section.
Configuration menu - View commit details
-
Copy full SHA for a45ab65 - Browse repository at this point
Copy the full SHA a45ab65View commit details -
Merge pull request #20 from cprice-puppet/feature/master/detect-comme…
…nted-settings Add detection for commented versions of settings
Configuration menu - View commit details
-
Copy full SHA for 85afa27 - Browse repository at this point
Copy the full SHA 85afa27View commit details
Commits on Nov 2, 2012
-
Configuration menu - View commit details
-
Copy full SHA for 6a53230 - Browse repository at this point
Copy the full SHA 6a53230View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0.0.3...0.9.0