-
Notifications
You must be signed in to change notification settings - Fork 177
Comparing changes
Open a pull request
base repository: puppetlabs/puppetlabs-inifile
base: 1.0.4
head repository: puppetlabs/puppetlabs-inifile
compare: 1.1.0
- 18 commits
- 11 files changed
- 5 contributors
Commits on Apr 18, 2014
-
1
Configuration menu - View commit details
-
Copy full SHA for 77429f6 - Browse repository at this point
Copy the full SHA 77429f6View commit details
Commits on Apr 23, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 790aa9c - Browse repository at this point
Copy the full SHA 790aa9cView commit details
Commits on May 7, 2014
-
Add quote_char parameter to the ini_subsetting resource type
The quote_char is used to quote the entire setting when it is modified as a result of changes to some subsettings. For an example let's assume we have a setting of this form: JAVA_ARGS=-Xmx256m and we want to add the '-Xms' parameter to the setting, for that purpose we define a resource like this: ini_subsetting { '-Xms': ensure => present, path => '/some/config/file', section => '', setting => 'JAVA_ARGS', subsetting => '-Xms' value => '256m', } which results into the following setting: JAVA_ARGS=-Xmx256m -Xms256m But this is not what we intended - if this setting is read by the bash shell the '-Xms256m' parameter is interpreted as a command to be executed rather than a value to be assigned to the JAVA_ARGS variable. To fix this problem the quote_char parameter was added to the ini_subsetting resource type, and we'll take advantage of it to fix the problem in the above example like so: ini_subsetting { '-Xms': ensure => present, path => '/some/config/file', section => '', setting => 'JAVA_ARGS', quote_char => '"', subsetting => '-Xms' value => '256m', } which will result into: JAVA_ARGS="-Xmx256m -Xms256m" which is what we intended.Configuration menu - View commit details
-
Copy full SHA for 560bbc6 - Browse repository at this point
Copy the full SHA 560bbc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 77854d5 - Browse repository at this point
Copy the full SHA 77854d5View commit details
Commits on May 13, 2014
-
Merge branch '1.0.x' into 10xmerge
Ashley Penney committedMay 13, 2014 Configuration menu - View commit details
-
Copy full SHA for e24dd91 - Browse repository at this point
Copy the full SHA e24dd91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85f00fe - Browse repository at this point
Copy the full SHA 85f00feView commit details -
Add RHEL7 and Ubuntu 14.04 support.
Ashley Penney committedMay 13, 2014 Configuration menu - View commit details
-
Copy full SHA for 61203df - Browse repository at this point
Copy the full SHA 61203dfView commit details -
Merge pull request #97 from apenney/add-platforms
Add RHEL7 and Ubuntu 14.04 support.
Ashley Penney committedMay 13, 2014 Configuration menu - View commit details
-
Copy full SHA for 6656f02 - Browse repository at this point
Copy the full SHA 6656f02View commit details
Commits on May 16, 2014
-
Merge pull request #95 from mruzicka/feature/master/quote-char-parame…
…ter-for-subsetting Add quote_char parameter to the ini_subsetting resource type
Ashley Penney committedMay 16, 2014 Configuration menu - View commit details
-
Copy full SHA for d4a2b22 - Browse repository at this point
Copy the full SHA d4a2b22View commit details -
Ashley Penney committed
May 16, 2014 Configuration menu - View commit details
-
Copy full SHA for a5b34ea - Browse repository at this point
Copy the full SHA a5b34eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for b366981 - Browse repository at this point
Copy the full SHA b366981View commit details
Commits on May 19, 2014
-
Ashley Penney committed
May 19, 2014 Configuration menu - View commit details
-
Copy full SHA for 027b7bc - Browse repository at this point
Copy the full SHA 027b7bcView commit details
Commits on May 21, 2014
-
Update PE version requirement.
Also fixes spec_helper_acceptance to use install_puppet.
Morgan Haskel committedMay 21, 2014 Configuration menu - View commit details
-
Copy full SHA for 783fa4d - Browse repository at this point
Copy the full SHA 783fa4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6477d20 - Browse repository at this point
Copy the full SHA 6477d20View commit details
Commits on May 29, 2014
-
Configuration menu - View commit details
-
Copy full SHA for 6fb89f5 - Browse repository at this point
Copy the full SHA 6fb89f5View commit details -
Merge pull request #101 from hunner/remove_stderr
Remove stderr checks because of deprecations
Morgan Haskel committedMay 29, 2014 Configuration menu - View commit details
-
Copy full SHA for 0b9f9e2 - Browse repository at this point
Copy the full SHA 0b9f9e2View commit details
Commits on Jun 4, 2014
-
This is a compatibility and feature release. This release adds one new feature, the ability to control the quote character used. This allows you to do things like: ```puppet ini_subsetting { '-Xms': ensure => present, path => '/some/config/file', section => '', setting => 'JAVA_ARGS', quote_char => '"', subsetting => '-Xms' value => '256m', } ``` Which builds: ``` JAVA_ARGS="-Xmx256m -Xms256m" ```Configuration menu - View commit details
-
Copy full SHA for 521b287 - Browse repository at this point
Copy the full SHA 521b287View commit details -
Configuration menu - View commit details
-
Copy full SHA for e21dc0c - Browse repository at this point
Copy the full SHA e21dc0cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.0.4...1.1.0