Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-inifile
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.0.4
Choose a base ref
...
head repository: puppetlabs/puppetlabs-inifile
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.1.0
Choose a head ref
  • 18 commits
  • 11 files changed
  • 5 contributors

Commits on Apr 18, 2014

  1. be more igorant

    igalic committed Apr 18, 2014
    1 Configuration menu
    Copy the full SHA
    77429f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2014

  1. Merge pull request #94 from igalic/igorance

    be more ignorant
    Ashley Penney committed Apr 23, 2014
    Configuration menu
    Copy the full SHA
    790aa9c View commit details
    Browse the repository at this point in the history

Commits on May 7, 2014

  1. Add quote_char parameter to the ini_subsetting resource type

    The quote_char is used to quote the entire setting when it is modified
    as a result of changes to some subsettings.
    
    For an example let's assume we have a setting of this form:
      JAVA_ARGS=-Xmx256m
    and we want to add the '-Xms' parameter to the setting, for that purpose
    we define a resource like this:
      ini_subsetting { '-Xms':
        ensure     => present,
        path       => '/some/config/file',
        section    => '',
        setting    => 'JAVA_ARGS',
        subsetting => '-Xms'
        value      => '256m',
      }
    which results into the following setting:
      JAVA_ARGS=-Xmx256m -Xms256m
    But this is not what we intended - if this setting is read by the bash
    shell the '-Xms256m' parameter is interpreted as a command to be
    executed rather than a value to be assigned to the JAVA_ARGS variable.
    
    To fix this problem the quote_char parameter was added to the
    ini_subsetting resource type, and we'll take advantage of it to fix the
    problem in the above example like so:
      ini_subsetting { '-Xms':
        ensure     => present,
        path       => '/some/config/file',
        section    => '',
        setting    => 'JAVA_ARGS',
        quote_char => '"',
        subsetting => '-Xms'
        value      => '256m',
      }
    which will result into:
      JAVA_ARGS="-Xmx256m -Xms256m"
    which is what we intended.
    mruzicka committed May 7, 2014
    Configuration menu
    Copy the full SHA
    560bbc6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    77854d5 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2014

  1. Merge branch '1.0.x' into 10xmerge

    Ashley Penney committed May 13, 2014
    Configuration menu
    Copy the full SHA
    e24dd91 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #96 from apenney/10xmerge

    10xmerge
    Ashley Penney committed May 13, 2014
    Configuration menu
    Copy the full SHA
    85f00fe View commit details
    Browse the repository at this point in the history
  3. Add RHEL7 and Ubuntu 14.04 support.

    Ashley Penney committed May 13, 2014
    Configuration menu
    Copy the full SHA
    61203df View commit details
    Browse the repository at this point in the history
  4. Merge pull request #97 from apenney/add-platforms

    Add RHEL7 and Ubuntu 14.04 support.
    Ashley Penney committed May 13, 2014
    Configuration menu
    Copy the full SHA
    6656f02 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2014

  1. Merge pull request #95 from mruzicka/feature/master/quote-char-parame…

    …ter-for-subsetting
    
    Add quote_char parameter to the ini_subsetting resource type
    Ashley Penney committed May 16, 2014
    Configuration menu
    Copy the full SHA
    d4a2b22 View commit details
    Browse the repository at this point in the history
  2. Quick typo fix.

    Ashley Penney committed May 16, 2014
    Configuration menu
    Copy the full SHA
    a5b34ea View commit details
    Browse the repository at this point in the history
  3. Merge pull request #99 from apenney/typo-fix

    Quick typo fix.
    Ashley Penney committed May 16, 2014
    Configuration menu
    Copy the full SHA
    b366981 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2014

  1. Prepare a 1.1.x release.

    Ashley Penney committed May 19, 2014
    Configuration menu
    Copy the full SHA
    027b7bc View commit details
    Browse the repository at this point in the history

Commits on May 21, 2014

  1. Update PE version requirement.

    Also fixes spec_helper_acceptance to use install_puppet.
    Morgan Haskel committed May 21, 2014
    Configuration menu
    Copy the full SHA
    783fa4d View commit details
    Browse the repository at this point in the history
  2. Merge pull request #100 from mhaskel/1.1.0-prep

    1.1.0 prep
    Ashley Penney committed May 21, 2014
    Configuration menu
    Copy the full SHA
    6477d20 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2014

  1. Configuration menu
    Copy the full SHA
    6fb89f5 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #101 from hunner/remove_stderr

    Remove stderr checks because of deprecations
    Morgan Haskel committed May 29, 2014
    Configuration menu
    Copy the full SHA
    0b9f9e2 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2014

  1. Release 1.1.0

    This is a compatibility and feature release.  This release adds one new
    feature, the ability to control the quote character used.  This allows you to
    do things like:
    
    ```puppet
      ini_subsetting { '-Xms':
        ensure     => present,
        path       => '/some/config/file',
        section    => '',
        setting    => 'JAVA_ARGS',
        quote_char => '"',
        subsetting => '-Xms'
        value      => '256m',
      }
    ```
    
    Which builds:
    
    ```
    JAVA_ARGS="-Xmx256m -Xms256m"
    ```
    hunner committed Jun 4, 2014
    Configuration menu
    Copy the full SHA
    521b287 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #104 from hunner/release_1.1.0

    Release 1.1.0
    Morgan Haskel committed Jun 4, 2014
    Configuration menu
    Copy the full SHA
    e21dc0c View commit details
    Browse the repository at this point in the history
Loading